{{ message }}
Repository navigation
chore: upgrade to SvelteKit 3 - #970
Open
santiagosayshey wants to merge 11 commits into
Open
santiagosayshey wants to merge 11 commits into
santiagosayshey wants to merge 11 commits into
Conversation
This comment has been minimized.
This comment has been minimized.
Member
Author
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@claude review |
|
Re-run with |
This was referenced Oct 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
sv migrate sveltekit-3: config moves intovite.config.ts,$libbecomes#lib(subpath import in a minimalpackage.json),$app/environmentbecomes$app/env.$stores/page, a store over$app/state, since$app/storesis removed and$app/statedoesn't update in components without runes.invalidateAlltorefreshAll,json()toResponse.json(),gotoreplaceStatetoreplace.The remaining build warnings (custom aliases, Deno adapter API) are left for the Node migration in #963.
Related issue
Part of #963
User-facing docs
Dictionarry-Hub/profilarr.com#31 documents the
Content-Typerequirement on the Authentication page.Technical docs
docs/CONTRIBUTING.md,docs/backend/api.md,docs/backend/drift.md,docs/backend/security.md,docs/api/v1/openapi.yaml.Testing
Existing CI suites cover the change: build, lint, type checks, unit, integration and E2E auth. Integration tests were updated for Kit 3 behaviour: form action failures now return their real status, and the test client sends
Content-TypeonDELETE.No new tests, by decision:
Content-Typeis SvelteKit's own CSRF check, not our code. It was verified with curl against a preview build.$pageupdates and the two cross-page forms would need browser tests beyond the current E2E auth suite.$pageupdates were checked by hand in a preview build; the two forms were checked against SvelteKit'senhancesource.Upgrade impact
API requests that change data (
POST,PUT,PATCH,DELETE) must send aContent-Typeheader, e.g.Content-Type: application/json. Requests without one are rejected with403.This is an accepted trade-off. SvelteKit 3's CSRF check runs before our hooks, so exempting API key requests would need a custom server or adapter. The Node migration (#963) moves to the official adapter-node specifically to stop maintaining one.
Confirmation