Remove export of old dxi-menu-item from DxListModule by alexslavr · Pull Request #33381 · DevExpress/DevExtreme · GitHub
Skip to content

Remove export of old dxi-menu-item from DxListModule#33381

Merged
alexslavr merged 2 commits into
26_1from
lavrov/remove-old-list-menu-item
Apr 23, 2026
Merged

Remove export of old dxi-menu-item from DxListModule#33381
alexslavr merged 2 commits into
26_1from
lavrov/remove-old-list-menu-item

Conversation

@alexslavr

Copy link
Copy Markdown
Contributor

No description provided.

@alexslavr alexslavr requested a review from a team April 23, 2026 10:53
@alexslavr alexslavr self-assigned this Apr 23, 2026
Copilot AI review requested due to automatic review settings April 23, 2026 10:53
@alexslavr alexslavr force-pushed the lavrov/remove-old-list-menu-item branch from 02b9e72 to abcd50d Compare April 23, 2026 10:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Angular wrapper generation configuration and the generated DxListModule exports to stop re-exporting the legacy dxi-menu-item nested component from the List module, avoiding selector collisions and encouraging use of the list-specific nested component.

Changes:

  • Added an Angular generator config list for nested components that should not be exported (DxiToolbarItem, DxiMenuItem).
  • Removed DxiMenuItemModule (from devextreme-angular/ui/nested) from DxListModule’s imports/exports.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
tools/generators-config.js Adds generator configuration to prevent exporting specific legacy nested components in Angular output.
packages/devextreme-angular/src/ui/list/index.ts Stops exporting the legacy DxiMenuItemModule from DxListModule, leaving the list-specific DxiListMenuItemModule as the supported API.

@alexslavr alexslavr merged commit 5336207 into 26_1 Apr 23, 2026
177 of 179 checks passed
@alexslavr alexslavr deleted the lavrov/remove-old-list-menu-item branch April 23, 2026 12:52
sjbur pushed a commit to sjbur/DevExtreme that referenced this pull request May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants