iframe-proxy

christopher-buss · 2026-09-07T19:43:07Z

fork() rejects windowsHide in TypeScript even though Node forwards the option to spawn() and uses it when creating cluster workers. Make ForkOptions extend CommonOptions, as suggested in discussion #75523.

Apply the same one-line correction to the latest, v22, v24, and v25 definitions. Existing child-process tests now exercise windowsHide with both fork overloads and retain coverage of timeout.

Use a meaningful title for the pull request. Include the name of the package modified.
Test the change in your own code. Compiled against the patched definitions and ran both fork overloads with windowsHide: true; stdout, IPC messages, and exit status were preserved.
Add or edit tests to reflect the change. The regression tests rejected windowsHide before the declaration change.
Follow the advice from the readme.
Avoid common mistakes.
Run pnpm test <package to test>. Passed pnpm test node, pnpm test node/v22, pnpm test node/v24, and pnpm test node/v25 across their supported TypeScript configurations.

For this existing definition:

Provide source context: Node's fork implementation forwards options to spawn, and its cluster worker implementation explicitly passes windowsHide to fork.
No version-number change is needed: this corrects an existing runtime API rather than introducing support for a new Node version.

Repository-wide test-all was not run; local validation was scoped to the Node packages in a sparse checkout.

Generated with Codex.

Extend CommonOptions as suggested in discussion DefinitelyTyped#75523 so fork accepts windowsHide without a local intersection type. Apply the same correction to the latest, v22, v24, and v25 definitions and exercise both overloads. Package checks pass for all four versions. A compiled runtime example preserves stdout, IPC, and successful exit with hidden forked workers. Co-authored-by: Codex <noreply@openai.com>

typescript-automation · 2026-09-07T19:43:43Z

@christopher-buss Thank you for submitting this PR!

This is a live comment that I will keep updated.

1 package in this PR

node (26.5) — on npm, on unpkg
- owner-approval: @Renegade334

Code Reviews

Because this is a widely-used package, a DT maintainer will need to review it before it can be merged.

You can test the changes of this PR in the Playground.

Status

✅ No merge conflicts
✅ Continuous integration tests have passed
✅ Most recent commit is approved by a DT maintainer

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.

Diagnostic Information: What the bot saw about this PR

{
  "type": "info",
  "now": "-",
  "pr_number": 75525,
  "author": "christopher-buss",
  "headCommitOid": "1d8eb21ae6a41f47c8f4bc1d26e500ccb4ce236e",
  "mergeBaseOid": "af92471c4aa594ef307ac159ba753cf6a4cc01a0",
  "lastPushDate": "2026-09-07T19:43:07.000Z",
  "lastActivityDate": "2026-09-15T20:27:56.000Z",
  "mergeOfferDate": "2026-09-15T20:26:38.000Z",
  "mergeRequestDate": "2026-09-15T20:27:56.000Z",
  "mergeRequestUser": "christopher-buss",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "tooManyCommits": false,
  "tooManyReviews": false,
  "popularityLevel": "Critical",
  "pkgInfo": [
    {
      "name": "node",
      "version": "26.5",
      "kind": "edit",
      "files": [
        {
          "path": "types/node/child_process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/node-tests/child_process.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v22/child_process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v22/test/child_process.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v24/child_process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v24/test/child_process.ts",
          "kind": "test"
        },
        {
          "path": "types/node/v25/child_process.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/node/v25/node-tests/child_process.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "Microsoft",
        "jkomyno",
        "r3nya",
        "btoueg",
        "touffy",
        "mohsen1",
        "galkin",
        "eps1lon",
        "WilcoBakker",
        "chyzwar",
        "trivikr",
        "yoursunny",
        "qwelias",
        "ExE-Boss",
        "peterblazejewicz",
        "addaleax",
        "victorperin",
        "NodeJS",
        "LinusU",
        "wafuwafu13",
        "mcollina",
        "Semigradsky",
        "Renegade334",
        "anonrig"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Critical"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "RyanCavanaugh",
      "date": "2026-09-15T20:26:00.000Z",
      "isMaintainer": true
    },
    {
      "type": "approved",
      "reviewer": "Renegade334",
      "date": "2026-09-07T19:55:38.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 5575013456,
  "ciResult": "pass"
}

typescript-automation · 2026-09-07T19:43:45Z

🔔 @microsoft @jkomyno @r3nya @btoueg @Touffy @mohsen1 @galkin @eps1lon @WilcoBakker @chyzwar @trivikr @yoursunny @qwelias @ExE-Boss @peterblazejewicz @addaleax @victorperin @nodejs @LinusU @wafuwafu13 @mcollina @Semigradsky @Renegade334 @anonrig — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

Describe the existing windowsHide option and its false default alongside the other fork options, using the wording already documented for spawn. Refs: DefinitelyTyped/DefinitelyTyped#75525 Signed-off-by: christopher-buss <christopher.buss+github@protonmail.com> Assisted-by: Codex Co-authored-by: Codex <noreply@openai.com> PR-URL: #65887 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

christopher-buss · 2026-09-11T05:14:43Z

The doc change was merged into node if this helps at all :)

typescript-automation · 2026-09-15T20:26:38Z

@christopher-buss: Everything looks good here. I am ready to merge this PR (at 1d8eb21) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@microsoft, @jkomyno, @r3nya, @btoueg, @Touffy, @mohsen1, @galkin, @eps1lon, @WilcoBakker, @chyzwar, @trivikr, @yoursunny, @qwelias, @ExE-Boss, @peterblazejewicz, @addaleax, @victorperin, @nodejs, @LinusU, @wafuwafu13, @mcollina, @Semigradsky, @Renegade334, @anonrig: you can do this too.)

christopher-buss · 2026-09-15T20:27:56Z

Describe the existing windowsHide option and its false default alongside the other fork options, using the wording already documented for spawn. Refs: DefinitelyTyped/DefinitelyTyped#75525 Signed-off-by: christopher-buss <christopher.buss+github@protonmail.com> Assisted-by: Codex Co-authored-by: Codex <noreply@openai.com> PR-URL: #65887 Reviewed-By: Xuguang Mei <meixuguang@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

christopher-buss requested review from eps1lon and peterblazejewicz as code owners September 7, 2026 19:43

typescript-automation Bot added the Critical package label Sep 7, 2026

typescript-automation Bot added this to Pull Request Status Board Sep 7, 2026

typescript-automation Bot moved this to Waiting for Code Reviews in Pull Request Status Board Sep 7, 2026

Renegade334 approved these changes Sep 7, 2026

View reviewed changes

typescript-automation Bot added the Owner Approved A listed owner of this package signed off on the pull request. label Sep 7, 2026

typescript-automation Bot moved this from Waiting for Code Reviews to Needs Maintainer Review in Pull Request Status Board Sep 7, 2026

This was referenced Sep 7, 2026

doc: document windowsHide for child_process.fork nodejs/node#65887

Merged

fix(core): hide Windows consoles for task and plugin workers nrwl/nx#36945

Open

RyanCavanaugh approved these changes Sep 15, 2026

View reviewed changes

typescript-automation Bot added Maintainer Approved Self Merge This PR can now be self-merged by the PR author or an owner labels Sep 15, 2026

typescript-automation Bot moved this from Needs Maintainer Review to Waiting for Author to Merge in Pull Request Status Board Sep 15, 2026

typescript-automation Bot moved this from Waiting for Author to Merge to Recently Merged in Pull Request Status Board Sep 15, 2026

typescript-automation Bot merged commit e839b8f into DefinitelyTyped:master Sep 15, 2026
15 checks passed

christopher-buss deleted the fix/node-fork-windows-hide branch September 15, 2026 20:33

emremutlu08 mentioned this pull request Sep 18, 2026

Update Node 24 type definitions to 24.13.5 emremutlu08/hydrogenexpert#180

Merged

cursor Bot mentioned this pull request Sep 21, 2026

build(deps-dev): bump @types/node from 26.5.1 to 26.6.1 in the dev-dependencies group chhoumann/MetaEdit#209

Merged

typescript-automation Bot removed this from Pull Request Status Board Sep 29, 2026

github-actions Bot mentioned this pull request Sep 30, 2026

chore(deps): update dependency @types/node to v24.13.5 victoraugustoas/finance-manager#146

Merged

1 task

Sunbelt Computer Software

PL/B Language Development and Support

Navigation Menu

Repository navigation

[node] Inherit CommonOptions in ForkOptions to support windowsHide - #75525

[node] Inherit CommonOptions in ForkOptions to support windowsHide#75525
typescript-automation[bot] merged 1 commit into
DefinitelyTyped:masterfrom
christopher-buss:fix/node-fork-windows-hide

christopher-buss commented Sep 7, 2026

Uh oh!

typescript-automation Bot commented Sep 7, 2026 •

edited

Loading

Uh oh!

typescript-automation Bot commented Sep 7, 2026

Uh oh!

christopher-buss commented Sep 11, 2026

Uh oh!

typescript-automation Bot commented Sep 15, 2026

Uh oh!

christopher-buss commented Sep 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

christopher-buss commented Sep 7, 2026

Uh oh!

typescript-automation Bot commented Sep 7, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

1 package in this PR

Code Reviews

Status

Uh oh!

typescript-automation Bot commented Sep 7, 2026

Uh oh!

christopher-buss commented Sep 11, 2026

Uh oh!

typescript-automation Bot commented Sep 15, 2026

Uh oh!

christopher-buss commented Sep 15, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

typescript-automation Bot commented Sep 7, 2026 •

edited

Loading