add TaskBlock events for blocking intervals by kaahos · Pull Request #570 · DataDog/java-profiler · GitHub
Skip to content

add TaskBlock events for blocking intervals#570

Open
kaahos wants to merge 63 commits into
mainfrom
paul.fournillon/wallclock-taskblock
Open

add TaskBlock events for blocking intervals#570
kaahos wants to merge 63 commits into
mainfrom
paul.fournillon/wallclock-taskblock

Conversation

@kaahos

@kaahos kaahos commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?:

Adds datadog.TaskBlock JFR events for blocking intervals such as LockSupport.park, Object.wait, monitor contention, including recording APIs used by dd-trace-java for instrumented blocking operations such as Thread.sleep.

Motivation:

This builds on paul.fournillon/wallclock-suppression (#560) by preserving visibility into blocked spans as explicit duration events.

Additional Notes:

This PR does not add the dd-trace-java instrumentation itself; Thread.sleep emission depends on that side calling the new profiler APIs. Monitor callback support is HotSpot-specific, and virtual-thread carrier attribution is avoided.

How to test the change?:

  • ./.claude/commands/build-and-summarize :ddprof-test:testDebug -Ptests="*.wallclock.*TaskBlockTest"
  • ./.claude/commands/build-and-summarize :ddprof-lib:gtestDebug

For Datadog employees:

  • If this PR touches code that signs or publishes builds or packages, or handles
    credentials of any kind, I've requested a review from @DataDog/security-design-and-guidance.
  • This PR doesn't touch any of that.
  • JIRA: [JIRA-14354]

Unsure? Have a question? Request a review!

@datadog-datadog-prod-us1-2

datadog-datadog-prod-us1-2 Bot commented Jun 1, 2026 •
edited by datadog-official Bot
Loading

Copy link
Copy Markdown

@dd-octo-sts

dd-octo-sts Bot commented Jun 1, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

CI Test Results

Run: #28245769391 | Commit: 197cb8f | Duration: 14m 25s (longest job)

❌ 5 of 32 test jobs failed

Status Overview

JDK glibc-aarch64/debug glibc-amd64/debug musl-aarch64/debug musl-amd64/debug
8 - ✅ - -
8-ibm - ✅ - -
8-j9 ✅ ✅ - -
8-librca - - ❌ ✅
8-orcl - ✅ - -
11 - ✅ - -
11-j9 ✅ ✅ - -
11-librca - - ❌ ✅
17 ✅ ✅ - -
17-graal ✅ ✅ - -
17-j9 ✅ ✅ - -
17-librca - - ❌ ✅
21 ✅ ✅ - -
21-graal ✅ ✅ - -
21-librca - - ❌ ✅
25 ✅ ✅ - -
25-graal ✅ ✅ - -
25-librca - - ❌ ✅

Legend: ✅ passed | ❌ failed | ⚪ skipped | 🚫 cancelled

Failed Tests

musl-aarch64/debug / 25-librca

Job: View logs

No detailed failure information available. Check the job logs.

musl-aarch64/debug / 8-librca

Job: View logs

No detailed failure information available. Check the job logs.

musl-aarch64/debug / 21-librca

Job: View logs

No detailed failure information available. Check the job logs.

musl-aarch64/debug / 17-librca

Job: View logs

No detailed failure information available. Check the job logs.

musl-aarch64/debug / 11-librca

Job: View logs

No detailed failure information available. Check the job logs.

Summary: Total: 32 | Passed: 27 | Failed: 5

Updated: 2026-06-26 15:08:21 UTC

@kaahos kaahos force-pushed the paul.fournillon/wallclock-taskblock branch from bcf3c2b to a46d368 Compare June 2, 2026 08:24
@kaahos kaahos force-pushed the paul.fournillon/wallclock-taskblock branch 3 times, most recently from 3f2f71a to d1e3210 Compare June 3, 2026 13:00
@kaahos

kaahos commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

@copilot review this PR

Copilot AI commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Copilot finished work on behalf of kaahos June 3, 2026 13:27
@kaahos kaahos marked this pull request as ready for review June 3, 2026 13:40
@kaahos kaahos requested a review from a team as a code owner June 3, 2026 13:40
chatgpt-codex-connector[bot]
chatgpt-codex-connector Bot reviewed Jun 3, 2026
View reviewed changes

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d21e4936d2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread ddprof-lib/src/main/cpp/wallClock.cpp Outdated
@kaahos kaahos force-pushed the paul.fournillon/wallclock-taskblock branch 2 times, most recently from 2101007 to a94677a Compare June 3, 2026 14:05
@kaahos kaahos force-pushed the paul.fournillon/wallclock-taskblock branch from a94677a to 681582c Compare June 3, 2026 14:38
kaahos added 17 commits June 24, 2026 14:45
@kaahos
fix: fix native socket hook correctness
2a8c253
@kaahos
fix: fix blocked-run ownership and exit races and add TaskBlockQueue …
cf4fa5c 
…concurrency coverage test
@kaahos
fix: refresh native socket fd type after dup2 and dup3
0965b24
@kaahos
fix: document native patcher and call trace concurrency invariants
5619dd4
@kaahos
fix: make TaskBlock events carry direct stack references
b22b339
@kaahos
fix: test TaskBlock stack reference capture
9bbe994
@kaahos
test: assert TaskBlock events are self-contained in JFR tests
f6e7a92
@kaahos
fix: move TaskBlock diagnostics to profiler counters
a3b5edc
@kaahos
fix: fix comments
e2d5173
@kaahos
fix: fix TaskBlock stack recording
61e0bc0
@kaahos
fix: fix native socket fd cache invalidation
ccad290
@kaahos
fix: clean up NativeSocketInterposer helpers
a24ebfa
@kaahos
fix: clarify LibraryPatcher socket hook comments
d9f3316
@kaahos
fix: harden native TaskBlock recording paths
0e9eba6
@kaahos
fix: harden native socket interposer classification
8dfbe0d
@kaahos
test: expand Java TaskBlock integration coverage
e2bcb4c
@kaahos
test: cover TaskBlock lifecycle and degradation behavior
a7f38f6
@kaahos kaahos force-pushed the paul.fournillon/wallclock-taskblock branch from e760331 to a7f38f6 Compare June 24, 2026 13:06
@kaahos kaahos force-pushed the paul.fournillon/wallclock-taskblock branch 3 times, most recently from 68fa059 to fdbbbe8 Compare June 26, 2026 12:26
@kaahos kaahos force-pushed the paul.fournillon/wallclock-taskblock branch from fdbbbe8 to c862039 Compare June 26, 2026 12:59
@kaahos kaahos force-pushed the paul.fournillon/wallclock-taskblock branch from 3891f63 to bb6c93b Compare June 26, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbachorik jbachorik jbachorik requested changes
@chatgpt-codex-connector chatgpt-codex-connector[bot] chatgpt-codex-connector[bot] left review comments
@datadog-official datadog-official[bot] datadog-official[bot] left review comments

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@kaahos @jbachorik