Upload code coverage to Datadog by nikita-tkachenko-datadog · Pull Request #9132 · DataDog/dd-trace-java · GitHub
Skip to content

Upload code coverage to Datadog#9132

Merged
nikita-tkachenko-datadog merged 6 commits into
masterfrom
nikita-tkachenko/code-coverage-upload
Jul 10, 2025
Merged

Upload code coverage to Datadog#9132
nikita-tkachenko-datadog merged 6 commits into
masterfrom
nikita-tkachenko/code-coverage-upload

Conversation

@nikita-tkachenko-datadog

@nikita-tkachenko-datadog nikita-tkachenko-datadog commented Jul 9, 2025

Copy link
Copy Markdown
Contributor

What Does This Do

Configures uploading code coverage data to Datadog.

Motivation

Dogfooding new Code Coverage product.

Contributor Checklist

Jira ticket: [PROJ-IDENT]

@pr-commenter

pr-commenter Bot commented Jul 9, 2025

Copy link
Copy Markdown

@nikita-tkachenko-datadog nikita-tkachenko-datadog added comp: testing Testing tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements labels Jul 10, 2025
@nikita-tkachenko-datadog nikita-tkachenko-datadog marked this pull request as ready for review July 10, 2025 11:32
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested a review from a team as a code owner July 10, 2025 11:32
@nikita-tkachenko-datadog nikita-tkachenko-datadog requested review from TonyCTHsu and removed request for a team July 10, 2025 11:32

@PerfectSlayer PerfectSlayer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to test it or let's just give it a try?

Comment thread .gitlab/upload_ciapp.sh
# Upload test results to production environment like all other CI jobs
junit_upload "$DATADOG_API_KEY_PROD"

coverage_upload "$DATADOG_API_KEY_PROD"

@PerfectSlayer PerfectSlayer Jul 10, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the script return the result of both upload functions now? Not only the coverage one?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't it just fail if any of the uploads fails?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, nevermind, I realised the default is to just continue executing if a command fails. Updated the script to consider both statuses

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikita-tkachenko-datadog

Copy link
Copy Markdown
Contributor Author

Is there a way to test it or let's just give it a try?

It was tested by the CI jobs of this PR :)

Comment thread .gitlab/upload_ciapp.sh Outdated
Comment thread .gitlab/upload_ciapp.sh

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit a90ccbc into master Jul 10, 2025
674 of 675 checks passed
@nikita-tkachenko-datadog nikita-tkachenko-datadog deleted the nikita-tkachenko/code-coverage-upload branch July 10, 2025 16:06
@github-actions github-actions Bot added this to the 1.52.0 milestone Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp: testing Testing tag: no release notes Changes to exclude from release notes type: enhancement Enhancements and improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants