Ignore mise and asdf configuration files#9108
Conversation
bric3
added
tag: no release notes
There was a problem hiding this comment.
Perhaps we could also provide .config/mise.toml in the repo for easier setup? Can it setup JAVA_XX_HOME env vars?
There was a problem hiding this comment.
Good idea, I never looked into that.
There was a problem hiding this comment.
If we start adding custom config tool, we will end up having support for dozen of tools and not many people to maintain it :/
I would rather add support to install JDK from the setup scripts. Windows is already supported.
Linux and MacOS still needed. The tough part is to do it the more generic way without assuming nor requiring some specific tool.
There was a problem hiding this comment.
THis is very similar to any other env tool in many other languages.
I would rather add support to install JDK from the setup scripts.
My counterpoint is that setup script don;t manage JDK install well, other tools do that much better. For example the advantage of mise or asdf is they patch the PATH in the shell to the wanted JDK.
Also I wonder if we could leverage Gradle's JDK toolchain resolver (usually the foojay one), which hopefully don't preclude, other tools like mise or sdkman ?
Can it setup
JAVA_XX_HOMEenv vars?
I believe it's possible, however, it won't work in IntelliJ, as IJ captures environment variables produces by your ~/.zshrc. What I do have in mine is
export JAVA_8_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/corretto-8
export JAVA_11_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/corretto-11
export JAVA_17_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/corretto-17
export JAVA_21_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/corretto-21
export JAVA_GRAALVM17_HOME=/Users/brice.dutheil/.local/share/mise/installs/java/graalvm-community-17.0.9
Does are symlinks pointing to the latest installed JDK installed my mise.
FYI the mise configuration doc
There was a problem hiding this comment.
On the point of using .gitignore, is that it will be available for any clone, and thus avoiding accidental commit.
PerfectSlayer
left a comment
PerfectSlayer
left a comment
There was a problem hiding this comment.
May an unpopular opinion but I would rather avoid adding many custom tools to the common ignore list.
If you have some specific file to exclude related to your setup, the .git/info/exclude seems more appropriate.
There was a problem hiding this comment.
If we start adding custom config tool, we will end up having support for dozen of tools and not many people to maintain it :/
I would rather add support to install JDK from the setup scripts. Windows is already supported.
Linux and MacOS still needed. The tough part is to do it the more generic way without assuming nor requiring some specific tool.
bric3
force-pushed
the
bdu/ignore-asdf-mise
branch
from
9897ef9 to
14ccb1a
Compare
4 participants
What Does This Do
Motivation
Additional Notes
Contributor Checklist
type:and (comp:orinst:) labels in addition to any usefull labelsclose,fixor any linking keywords when referencing an issue.Use
solvesinstead, and assign the PR milestone to the issueJira ticket: [PROJ-IDENT]