iframe-proxy

mhlidd · 2025-04-21T22:44:05Z

What Does This Do

Previously, the Baggage Cache implemented injected incoming headers if no modification to baggage was made while ignoring limits. In order to be in compliance with limits, this PR adds support to truncate the baggage cache if limits are violated. Furthermore, Java does not support sending non-ascii characters in http headers. This PR also forcefully builds a outgoing baggage header if the incoming header includes non-encoded non-ascii characters by disabling the cache when extracting such headers.

Motivation

Additional Notes

Verified through unit tests and system-tests in test_baggage.py.

Contributor Checklist

Format the title according the contribution guidelines
Assign the type: and (comp: or inst:) labels in addition to any usefull labels
Don't use close, fix or any linking keywords when referencing an issue.
Use solves instead, and assign the PR milestone to the issue
Update the public documentation in case of new configuration flag or behavior

Jira ticket: [PROJ-IDENT]

pr-commenter · 2025-04-21T23:38:27Z

Benchmarks

Startup

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/update_baggage_limits
git_commit_date	1746209194	1746212094
git_commit_sha	`5a04e8c`	`a1e5ffb`
release_version	1.49.0-SNAPSHOT~5a04e8c591	1.49.0-SNAPSHOT~a1e5ffbd50

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1746215451	1746215451
ci_job_id	922191473	922191473
ci_pipeline_id	64005991	64005991
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zazntmgv-project-304-concurrent-0-meknpn9d 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zazntmgv-project-304-concurrent-0-meknpn9d 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
module	Agent	Agent
parent	None	None
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 66 metrics, 5 unstable metrics.

Startup time reports for insecure-bank

gantt
    title insecure-bank - global startup overhead: candidate=1.49.0-SNAPSHOT~a1e5ffbd50, baseline=1.49.0-SNAPSHOT~5a04e8c591

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.006 s) : 0, 1006084
Total [baseline] (8.631 s) : 0, 8630771
Agent [candidate] (1.014 s) : 0, 1014375
Total [candidate] (8.647 s) : 0, 8646802
section iast
Agent [baseline] (1.135 s) : 0, 1134687
Total [baseline] (9.192 s) : 0, 9191899
Agent [candidate] (1.134 s) : 0, 1134352
Total [candidate] (9.203 s) : 0, 9202617
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.138 s) : 0, 1137599
Total [baseline] (9.248 s) : 0, 9247956
Agent [candidate] (1.142 s) : 0, 1141623
Total [candidate] (9.198 s) : 0, 9198465
section iast_TELEMETRY_OFF
Agent [baseline] (1.136 s) : 0, 1135650
Total [baseline] (9.212 s) : 0, 9211549
Agent [candidate] (1.14 s) : 0, 1140403
Total [candidate] (9.216 s) : 0, 9216496

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.006 s	-
Agent	iast	1.135 s	128.603 ms (12.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.138 s	131.515 ms (13.1%)
Agent	iast_TELEMETRY_OFF	1.136 s	129.566 ms (12.9%)
Total	tracing	8.631 s	-
Total	iast	9.192 s	561.128 ms (6.5%)
Total	iast_HARDCODED_SECRET_DISABLED	9.248 s	617.185 ms (7.2%)
Total	iast_TELEMETRY_OFF	9.212 s	580.778 ms (6.7%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.014 s	-
Agent	iast	1.134 s	119.977 ms (11.8%)
Agent	iast_HARDCODED_SECRET_DISABLED	1.142 s	127.249 ms (12.5%)
Agent	iast_TELEMETRY_OFF	1.14 s	126.028 ms (12.4%)
Total	tracing	8.647 s	-
Total	iast	9.203 s	555.815 ms (6.4%)
Total	iast_HARDCODED_SECRET_DISABLED	9.198 s	551.663 ms (6.4%)
Total	iast_TELEMETRY_OFF	9.216 s	569.694 ms (6.6%)

gantt
    title insecure-bank - break down per module: candidate=1.49.0-SNAPSHOT~a1e5ffbd50, baseline=1.49.0-SNAPSHOT~5a04e8c591

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.593 ms) : 0, 671593
BytebuddyAgent [candidate] (674.529 ms) : 0, 674529
GlobalTracer [baseline] (240.297 ms) : 0, 240297
GlobalTracer [candidate] (241.56 ms) : 0, 241560
AppSec [baseline] (54.66 ms) : 0, 54660
AppSec [candidate] (54.887 ms) : 0, 54887
Debugger [baseline] (6.868 ms) : 0, 6868
Debugger [candidate] (7.765 ms) : 0, 7765
Remote Config [baseline] (696.039 µs) : 0, 696
Remote Config [candidate] (707.368 µs) : 0, 707
Telemetry [baseline] (8.438 ms) : 0, 8438
Telemetry [candidate] (11.381 ms) : 0, 11381
section iast
BytebuddyAgent [baseline] (788.209 ms) : 0, 788209
BytebuddyAgent [candidate] (788.721 ms) : 0, 788721
GlobalTracer [baseline] (229.435 ms) : 0, 229435
GlobalTracer [candidate] (229.175 ms) : 0, 229175
IAST [baseline] (22.718 ms) : 0, 22718
IAST [candidate] (22.645 ms) : 0, 22645
AppSec [baseline] (56.553 ms) : 0, 56553
AppSec [candidate] (56.209 ms) : 0, 56209
Debugger [baseline] (5.903 ms) : 0, 5903
Debugger [candidate] (5.858 ms) : 0, 5858
Remote Config [baseline] (608.108 µs) : 0, 608
Remote Config [candidate] (597.761 µs) : 0, 598
Telemetry [baseline] (7.881 ms) : 0, 7881
Telemetry [candidate] (7.819 ms) : 0, 7819
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (790.455 ms) : 0, 790455
BytebuddyAgent [candidate] (792.16 ms) : 0, 792160
GlobalTracer [baseline] (229.508 ms) : 0, 229508
GlobalTracer [candidate] (231.676 ms) : 0, 231676
IAST [baseline] (22.765 ms) : 0, 22765
IAST [candidate] (23.015 ms) : 0, 23015
AppSec [baseline] (56.997 ms) : 0, 56997
AppSec [candidate] (56.806 ms) : 0, 56806
Debugger [baseline] (5.938 ms) : 0, 5938
Debugger [candidate] (5.936 ms) : 0, 5936
Remote Config [baseline] (604.01 µs) : 0, 604
Remote Config [candidate] (595.298 µs) : 0, 595
Telemetry [baseline] (7.996 ms) : 0, 7996
Telemetry [candidate] (7.951 ms) : 0, 7951
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (787.744 ms) : 0, 787744
BytebuddyAgent [candidate] (792.483 ms) : 0, 792483
GlobalTracer [baseline] (231.011 ms) : 0, 231011
GlobalTracer [candidate] (230.922 ms) : 0, 230922
IAST [baseline] (22.557 ms) : 0, 22557
IAST [candidate] (22.344 ms) : 0, 22344
AppSec [baseline] (56.587 ms) : 0, 56587
AppSec [candidate] (56.814 ms) : 0, 56814
Debugger [baseline] (5.986 ms) : 0, 5986
Debugger [candidate] (5.98 ms) : 0, 5980
Remote Config [baseline] (603.155 µs) : 0, 603
Remote Config [candidate] (602.813 µs) : 0, 603
Telemetry [baseline] (7.766 ms) : 0, 7766
Telemetry [candidate] (7.781 ms) : 0, 7781

Startup time reports for petclinic

gantt
    title petclinic - global startup overhead: candidate=1.49.0-SNAPSHOT~a1e5ffbd50, baseline=1.49.0-SNAPSHOT~5a04e8c591

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.013 s) : 0, 1013049
Total [baseline] (10.485 s) : 0, 10485415
Agent [candidate] (1.015 s) : 0, 1015301
Total [candidate] (10.515 s) : 0, 10515289
section appsec
Agent [baseline] (1.148 s) : 0, 1148188
Total [baseline] (10.626 s) : 0, 10626058
Agent [candidate] (1.149 s) : 0, 1148664
Total [candidate] (10.675 s) : 0, 10674596
section iast
Agent [baseline] (1.144 s) : 0, 1144274
Total [baseline] (10.887 s) : 0, 10886942
Agent [candidate] (1.14 s) : 0, 1139640
Total [candidate] (10.876 s) : 0, 10875500
section profiling
Agent [baseline] (1.255 s) : 0, 1255404
Total [baseline] (10.837 s) : 0, 10837245
Agent [candidate] (1.264 s) : 0, 1263579
Total [candidate] (10.799 s) : 0, 10798875

baseline results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.013 s	-
Agent	appsec	1.148 s	135.139 ms (13.3%)
Agent	iast	1.144 s	131.225 ms (13.0%)
Agent	profiling	1.255 s	242.355 ms (23.9%)
Total	tracing	10.485 s	-
Total	appsec	10.626 s	140.644 ms (1.3%)
Total	iast	10.887 s	401.527 ms (3.8%)
Total	profiling	10.837 s	351.83 ms (3.4%)

candidate results

Module	Variant	Duration	Δ tracing
Agent	tracing	1.015 s	-
Agent	appsec	1.149 s	133.363 ms (13.1%)
Agent	iast	1.14 s	124.339 ms (12.2%)
Agent	profiling	1.264 s	248.278 ms (24.5%)
Total	tracing	10.515 s	-
Total	appsec	10.675 s	159.307 ms (1.5%)
Total	iast	10.876 s	360.212 ms (3.4%)
Total	profiling	10.799 s	283.586 ms (2.7%)

gantt
    title petclinic - break down per module: candidate=1.49.0-SNAPSHOT~a1e5ffbd50, baseline=1.49.0-SNAPSHOT~5a04e8c591

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (675.19 ms) : 0, 675190
BytebuddyAgent [candidate] (677.193 ms) : 0, 677193
GlobalTracer [baseline] (240.858 ms) : 0, 240858
GlobalTracer [candidate] (241.807 ms) : 0, 241807
AppSec [baseline] (55.057 ms) : 0, 55057
AppSec [candidate] (55.085 ms) : 0, 55085
Debugger [baseline] (6.208 ms) : 0, 6208
Debugger [candidate] (6.212 ms) : 0, 6212
Remote Config [baseline] (704.373 µs) : 0, 704
Remote Config [candidate] (706.689 µs) : 0, 707
Telemetry [baseline] (11.489 ms) : 0, 11489
Telemetry [candidate] (10.743 ms) : 0, 10743
section appsec
BytebuddyAgent [baseline] (688.142 ms) : 0, 688142
BytebuddyAgent [candidate] (688.098 ms) : 0, 688098
GlobalTracer [baseline] (236.141 ms) : 0, 236141
GlobalTracer [candidate] (236.199 ms) : 0, 236199
AppSec [baseline] (175.075 ms) : 0, 175075
AppSec [candidate] (175.78 ms) : 0, 175780
Debugger [baseline] (5.836 ms) : 0, 5836
Debugger [candidate] (5.886 ms) : 0, 5886
Remote Config [baseline] (630.453 µs) : 0, 630
Remote Config [candidate] (635.499 µs) : 0, 635
Telemetry [baseline] (8.109 ms) : 0, 8109
Telemetry [candidate] (7.792 ms) : 0, 7792
IAST [baseline] (21.749 ms) : 0, 21749
IAST [candidate] (21.837 ms) : 0, 21837
section iast
BytebuddyAgent [baseline] (795.513 ms) : 0, 795513
BytebuddyAgent [candidate] (791.918 ms) : 0, 791918
GlobalTracer [baseline] (231.175 ms) : 0, 231175
GlobalTracer [candidate] (230.431 ms) : 0, 230431
AppSec [baseline] (56.591 ms) : 0, 56591
AppSec [candidate] (56.558 ms) : 0, 56558
Debugger [baseline] (5.916 ms) : 0, 5916
Debugger [candidate] (5.874 ms) : 0, 5874
Remote Config [baseline] (598.338 µs) : 0, 598
Remote Config [candidate] (594.521 µs) : 0, 595
Telemetry [baseline] (7.975 ms) : 0, 7975
Telemetry [candidate] (8.044 ms) : 0, 8044
IAST [baseline] (22.928 ms) : 0, 22928
IAST [candidate] (22.805 ms) : 0, 22805
section profiling
BytebuddyAgent [baseline] (661.353 ms) : 0, 661353
BytebuddyAgent [candidate] (666.872 ms) : 0, 666872
GlobalTracer [baseline] (377.95 ms) : 0, 377950
GlobalTracer [candidate] (379.562 ms) : 0, 379562
AppSec [baseline] (54.637 ms) : 0, 54637
AppSec [candidate] (54.056 ms) : 0, 54056
Debugger [baseline] (6.141 ms) : 0, 6141
Debugger [candidate] (6.183 ms) : 0, 6183
Remote Config [baseline] (670.977 µs) : 0, 671
Remote Config [candidate] (649.368 µs) : 0, 649
Telemetry [baseline] (8.145 ms) : 0, 8145
Telemetry [candidate] (8.226 ms) : 0, 8226
ProfilingAgent [baseline] (96.408 ms) : 0, 96408
ProfilingAgent [candidate] (96.982 ms) : 0, 96982
Profiling [baseline] (96.432 ms) : 0, 96432
Profiling [candidate] (97.007 ms) : 0, 97007

Load

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
end_time	2025-05-02T19:19:54	2025-05-02T19:27:35
git_branch	master	mhlidd/update_baggage_limits
git_commit_date	1746209194	1746212094
git_commit_sha	`5a04e8c`	`a1e5ffb`
release_version	1.49.0-SNAPSHOT~5a04e8c591	1.49.0-SNAPSHOT~a1e5ffbd50
start_time	2025-05-02T19:19:40	2025-05-02T19:27:21

See matching parameters

	Baseline	Candidate
application	insecure-bank	insecure-bank
ci_job_date	1746214451	1746214451
ci_job_id	922191474	922191474
ci_pipeline_id	64005991	64005991
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-jbjrwcs-project-304-concurrent-0-erd183mt 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-jbjrwcs-project-304-concurrent-0-erd183mt 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	iast	iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 18 unstable metrics.

Request duration reports for petclinic

gantt
    title petclinic - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~a1e5ffbd50, baseline=1.49.0-SNAPSHOT~5a04e8c591
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.351 ms) : 1330, 1371
.   : milestone, 1351,
appsec (1.707 ms) : 1683, 1730
.   : milestone, 1707,
appsec_no_iast (1.703 ms) : 1679, 1727
.   : milestone, 1703,
code_origins (1.661 ms) : 1635, 1688
.   : milestone, 1661,
iast (1.508 ms) : 1485, 1532
.   : milestone, 1508,
profiling (1.505 ms) : 1482, 1529
.   : milestone, 1505,
tracing (1.477 ms) : 1452, 1501
.   : milestone, 1477,
section candidate
no_agent (1.346 ms) : 1326, 1366
.   : milestone, 1346,
appsec (1.742 ms) : 1719, 1765
.   : milestone, 1742,
appsec_no_iast (1.749 ms) : 1725, 1772
.   : milestone, 1749,
code_origins (1.676 ms) : 1650, 1703
.   : milestone, 1676,
iast (1.511 ms) : 1487, 1535
.   : milestone, 1511,
profiling (1.504 ms) : 1480, 1527
.   : milestone, 1504,
tracing (1.483 ms) : 1458, 1508
.   : milestone, 1483,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.351 ms [1.33 ms, 1.371 ms]	-
appsec	1.707 ms [1.683 ms, 1.73 ms]	356.369 µs (26.4%)
appsec_no_iast	1.703 ms [1.679 ms, 1.727 ms]	352.286 µs (26.1%)
code_origins	1.661 ms [1.635 ms, 1.688 ms]	310.742 µs (23.0%)
iast	1.508 ms [1.485 ms, 1.532 ms]	157.877 µs (11.7%)
profiling	1.505 ms [1.482 ms, 1.529 ms]	154.722 µs (11.5%)
tracing	1.477 ms [1.452 ms, 1.501 ms]	126.29 µs (9.4%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	1.346 ms [1.326 ms, 1.366 ms]	-
appsec	1.742 ms [1.719 ms, 1.765 ms]	395.742 µs (29.4%)
appsec_no_iast	1.749 ms [1.725 ms, 1.772 ms]	402.272 µs (29.9%)
code_origins	1.676 ms [1.65 ms, 1.703 ms]	329.961 µs (24.5%)
iast	1.511 ms [1.487 ms, 1.535 ms]	164.652 µs (12.2%)
profiling	1.504 ms [1.48 ms, 1.527 ms]	157.262 µs (11.7%)
tracing	1.483 ms [1.458 ms, 1.508 ms]	136.935 µs (10.2%)

Request duration reports for insecure-bank

gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.49.0-SNAPSHOT~a1e5ffbd50, baseline=1.49.0-SNAPSHOT~5a04e8c591
    dateFormat X
    axisFormat %s
section baseline
no_agent (377.892 µs) : 358, 398
.   : milestone, 378,
iast (523.743 µs) : 501, 547
.   : milestone, 524,
iast_FULL (739.047 µs) : 716, 762
.   : milestone, 739,
iast_GLOBAL (570.042 µs) : 547, 593
.   : milestone, 570,
iast_HARDCODED_SECRET_DISABLED (521.825 µs) : 499, 544
.   : milestone, 522,
iast_INACTIVE (470.399 µs) : 447, 494
.   : milestone, 470,
iast_TELEMETRY_OFF (510.111 µs) : 486, 534
.   : milestone, 510,
tracing (457.658 µs) : 436, 480
.   : milestone, 458,
section candidate
no_agent (381.601 µs) : 361, 402
.   : milestone, 382,
iast (516.144 µs) : 493, 539
.   : milestone, 516,
iast_FULL (731.67 µs) : 708, 755
.   : milestone, 732,
iast_GLOBAL (566.406 µs) : 543, 590
.   : milestone, 566,
iast_HARDCODED_SECRET_DISABLED (515.993 µs) : 493, 539
.   : milestone, 516,
iast_INACTIVE (464.876 µs) : 442, 487
.   : milestone, 465,
iast_TELEMETRY_OFF (512.491 µs) : 489, 536
.   : milestone, 512,
tracing (459.372 µs) : 437, 482
.   : milestone, 459,

baseline results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	377.892 µs [357.665 µs, 398.119 µs]	-
iast	523.743 µs [500.742 µs, 546.743 µs]	145.851 µs (38.6%)
iast_FULL	739.047 µs [715.689 µs, 762.405 µs]	361.155 µs (95.6%)
iast_GLOBAL	570.042 µs [547.089 µs, 592.994 µs]	192.149 µs (50.8%)
iast_HARDCODED_SECRET_DISABLED	521.825 µs [499.185 µs, 544.465 µs]	143.933 µs (38.1%)
iast_INACTIVE	470.399 µs [447.273 µs, 493.525 µs]	92.507 µs (24.5%)
iast_TELEMETRY_OFF	510.111 µs [486.323 µs, 533.9 µs]	132.219 µs (35.0%)
tracing	457.658 µs [435.522 µs, 479.794 µs]	79.766 µs (21.1%)

candidate results

Variant	Request duration [CI 0.99]	Δ no_agent
no_agent	381.601 µs [360.913 µs, 402.289 µs]	-
iast	516.144 µs [493.039 µs, 539.248 µs]	134.543 µs (35.3%)
iast_FULL	731.67 µs [708.069 µs, 755.271 µs]	350.069 µs (91.7%)
iast_GLOBAL	566.406 µs [543.103 µs, 589.71 µs]	184.806 µs (48.4%)
iast_HARDCODED_SECRET_DISABLED	515.993 µs [493.341 µs, 538.645 µs]	134.392 µs (35.2%)
iast_INACTIVE	464.876 µs [442.4 µs, 487.352 µs]	83.275 µs (21.8%)
iast_TELEMETRY_OFF	512.491 µs [489.367 µs, 535.615 µs]	130.89 µs (34.3%)
tracing	459.372 µs [437.112 µs, 481.633 µs]	77.772 µs (20.4%)

Dacapo

Parameters

	Baseline	Candidate
baseline_or_candidate	baseline	candidate
git_branch	master	mhlidd/update_baggage_limits
git_commit_date	1746209194	1746212094
git_commit_sha	`5a04e8c`	`a1e5ffb`
release_version	1.49.0-SNAPSHOT~5a04e8c591	1.49.0-SNAPSHOT~a1e5ffbd50

See matching parameters

	Baseline	Candidate
application	biojava	biojava
ci_job_date	1746215049	1746215049
ci_job_id	922191475	922191475
ci_pipeline_id	64005991	64005991
cpu_model	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz	Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
kernel_version	Linux runner-zazntmgv-project-304-concurrent-1-a93fa0wr 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux	Linux runner-zazntmgv-project-304-concurrent-1-a93fa0wr 6.8.0-1027-aws #29~22.04.1-Ubuntu SMP Sun Mar 30 07:45:38 UTC 2025 x86_64 x86_64 x86_64 GNU/Linux
variant	appsec	appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for tomcat

gantt
    title tomcat - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~a1e5ffbd50, baseline=1.49.0-SNAPSHOT~5a04e8c591
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.476 ms) : 1464, 1487
.   : milestone, 1476,
appsec (2.382 ms) : 2335, 2429
.   : milestone, 2382,
iast (2.154 ms) : 2095, 2213
.   : milestone, 2154,
iast_GLOBAL (2.208 ms) : 2148, 2268
.   : milestone, 2208,
profiling (2.037 ms) : 1987, 2086
.   : milestone, 2037,
tracing (1.978 ms) : 1933, 2024
.   : milestone, 1978,
section candidate
no_agent (1.473 ms) : 1461, 1484
.   : milestone, 1473,
appsec (2.367 ms) : 2320, 2414
.   : milestone, 2367,
iast (2.166 ms) : 2107, 2226
.   : milestone, 2166,
iast_GLOBAL (2.198 ms) : 2138, 2258
.   : milestone, 2198,
profiling (2.014 ms) : 1966, 2061
.   : milestone, 2014,
tracing (1.987 ms) : 1941, 2033
.   : milestone, 1987,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.476 ms [1.464 ms, 1.487 ms]	-
appsec	2.382 ms [2.335 ms, 2.429 ms]	906.085 µs (61.4%)
iast	2.154 ms [2.095 ms, 2.213 ms]	678.142 µs (46.0%)
iast_GLOBAL	2.208 ms [2.148 ms, 2.268 ms]	732.275 µs (49.6%)
profiling	2.037 ms [1.987 ms, 2.086 ms]	560.728 µs (38.0%)
tracing	1.978 ms [1.933 ms, 2.024 ms]	502.276 µs (34.0%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	1.473 ms [1.461 ms, 1.484 ms]	-
appsec	2.367 ms [2.32 ms, 2.414 ms]	894.113 µs (60.7%)
iast	2.166 ms [2.107 ms, 2.226 ms]	693.339 µs (47.1%)
iast_GLOBAL	2.198 ms [2.138 ms, 2.258 ms]	725.099 µs (49.2%)
profiling	2.014 ms [1.966 ms, 2.061 ms]	540.662 µs (36.7%)
tracing	1.987 ms [1.941 ms, 2.033 ms]	513.633 µs (34.9%)

Execution time for biojava

gantt
    title biojava - execution time [CI 0.99] : candidate=1.49.0-SNAPSHOT~a1e5ffbd50, baseline=1.49.0-SNAPSHOT~5a04e8c591
    dateFormat X
    axisFormat %s
section baseline
no_agent (14.951 s) : 14951000, 14951000
.   : milestone, 14951000,
appsec (14.912 s) : 14912000, 14912000
.   : milestone, 14912000,
iast (19.251 s) : 19251000, 19251000
.   : milestone, 19251000,
iast_GLOBAL (18.242 s) : 18242000, 18242000
.   : milestone, 18242000,
profiling (15.058 s) : 15058000, 15058000
.   : milestone, 15058000,
tracing (14.908 s) : 14908000, 14908000
.   : milestone, 14908000,
section candidate
no_agent (15.641 s) : 15641000, 15641000
.   : milestone, 15641000,
appsec (15.027 s) : 15027000, 15027000
.   : milestone, 15027000,
iast (18.514 s) : 18514000, 18514000
.   : milestone, 18514000,
iast_GLOBAL (18.129 s) : 18129000, 18129000
.   : milestone, 18129000,
profiling (14.944 s) : 14944000, 14944000
.   : milestone, 14944000,
tracing (14.907 s) : 14907000, 14907000
.   : milestone, 14907000,

baseline results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	14.951 s [14.951 s, 14.951 s]	-
appsec	14.912 s [14.912 s, 14.912 s]	-39.0 ms (-0.3%)
iast	19.251 s [19.251 s, 19.251 s]	4.3 s (28.8%)
iast_GLOBAL	18.242 s [18.242 s, 18.242 s]	3.291 s (22.0%)
profiling	15.058 s [15.058 s, 15.058 s]	107.0 ms (0.7%)
tracing	14.908 s [14.908 s, 14.908 s]	-43.0 ms (-0.3%)

candidate results

Variant	Execution Time [CI 0.99]	Δ no_agent
no_agent	15.641 s [15.641 s, 15.641 s]	-
appsec	15.027 s [15.027 s, 15.027 s]	-614.0 ms (-3.9%)
iast	18.514 s [18.514 s, 18.514 s]	2.873 s (18.4%)
iast_GLOBAL	18.129 s [18.129 s, 18.129 s]	2.488 s (15.9%)
profiling	14.944 s [14.944 s, 14.944 s]	-697.0 ms (-4.5%)
tracing	14.907 s [14.907 s, 14.907 s]	-734.0 ms (-4.7%)

github-actions · 2025-04-22T21:06:43Z

Hi! 👋 Thanks for your pull request! 🎉

To help us review it, please make sure to:

Add at least one type, and one component or instrumentation label to the pull request

If you need help, please check our contributing guidelines.

mhlidd · 2025-04-23T19:28:25Z

+  public boolean keyNeedsEncoding(String key) {
+    int slen = key.length();
+    for (int index = 0; index < slen; index++) {
+      char c = key.charAt(index);
+      if (needsEncoding(c, unsafeKeyOctets)) {
+        return true;
+      }
+    }
+    return false;
+  }
+
+  public boolean valNeedsEncoding(String val) {


I included both of these to avoid checking which unsafe characters to use for each string we decode. Let me know if that is preferred for code-conciseness

No that’s good 👍
But you can make it more concise if you like by still having the public boolean keyNeedsEncoding(String key) and public boolean valNeedsEncoding(String val) that calls an private method public boolean needsEncoding(String s, boolean[] unsafeOctets) and do all the logic / iteration on this single method (the length, for, charAt, etc...).

PerfectSlayer · 2025-04-24T14:33:16Z

I had a quick look Today but will complete the review Tomorrow.
Quick question though, have you though about jmh benchmark to check the impact of this change?

mhlidd · 2025-04-24T16:42:29Z

I had a quick look Today but will complete the review Tomorrow. Quick question though, have you though about jmh benchmark to check the impact of this change?

No I have not, I will look into that today!

mhlidd · 2025-04-25T18:47:20Z

I had a quick look Today but will complete the review Tomorrow. Quick question though, have you though about jmh benchmark to check the impact of this change?

No I have not, I will look into that today!

Temporarily, the baggage propagator benchmarks are included here!

PerfectSlayer

I left few comments. The main one is about dropping invalid header at extraction which seems conflicting with the non-ascii parsing.

PerfectSlayer · 2025-04-29T11:11:43Z

+          } else{
+            this.w3cHeader = input.substring(0, start - 1); // -1 to ignore the k/v separator
+          }
+          truncatedCache = true;


You should break here if you reach max size or max bytes.
It will simply the if clause too.

Even if we don't cache here, we still need to maintain all of the raw baggage data so we can't break.

PerfectSlayer · 2025-04-29T11:14:11Z


+        // need to percent-encode non-ascii headers we pass down
+        if (UTF_ESCAPER.keyNeedsEncoding(key) || UTF_ESCAPER.valNeedsEncoding(value)) {
+          truncatedCache = true;


It’s not strictly truncated, it’s invalid in this case as non ascii characters are not allowed in HTTP headers. I though the RFC asked to drop the header and not parse it if it was invalid.

From RFC encoding:

In other words, the HTTP baggage header is encoded using only ASCII characters.

From RFC error handling:

When this occurs, the APM SDK should not try to extract any values from the entire header. In other words, APM SDKs should ignore the header and not try to extract "good" values while ignoring "bad" ones.

I would argue that this isn't an invalid case and should be something that we can support since HTTP clients technically can send non-ascii characters as headers and we do support non-ascii characters as baggage. I would say that the invalid case is more for parsing issues with not being able to figure out what baggage should be used.

PerfectSlayer · 2025-04-29T11:18:41Z

+  public boolean keyNeedsEncoding(String key) {
+    int slen = key.length();
+    for (int index = 0; index < slen; index++) {
+      char c = key.charAt(index);
+      if (needsEncoding(c, unsafeKeyOctets)) {
+        return true;
+      }
+    }
+    return false;
+  }
+
+  public boolean valNeedsEncoding(String val) {


No that’s good 👍
But you can make it more concise if you like by still having the public boolean keyNeedsEncoding(String key) and public boolean valNeedsEncoding(String val) that calls an private method public boolean needsEncoding(String s, boolean[] unsafeOctets) and do all the logic / iteration on this single method (the length, for, charAt, etc...).

PerfectSlayer

Looking good! 👍

I added a test case about the non-ASCII header to check it behaves as expected and simplify config usage in the propagator.

mhlidd · 2025-05-02T15:32:48Z

| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `1.49.0` -> `1.50.0` | --- ### Release Notes <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.50.0`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.0): 1.50.0 ### Deprecation Notice > \[!NOTE] > `DD_RUNTIME_ID_ENABLED` has been deprecated and will be removed in future releases. Please use `DD_RUNTIME_METRICS_RUNTIME_ID_ENABLED` instead. ### Components #### Application Security Management (WAF) - 🐛 Add String length truncation limit to ObjectIntrospector and update truncation metrics ([#8825](DataDog/dd-trace-java#8825) - [@jandro996](https://github.com/jandro996)) - 🐛 Adapt standalone ASM to support API Security ([#8804](DataDog/dd-trace-java#8804) - [@jandro996](https://github.com/jandro996)) - ✨ Add appsec.waf.input\_truncated metric ([#8791](DataDog/dd-trace-java#8791) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request body collection ([#8748](DataDog/dd-trace-java#8748) - [@jandro996](https://github.com/jandro996)) - ✨ Extended appsec request/response headers collection ([#8724](DataDog/dd-trace-java#8724) - [@jandro996](https://github.com/jandro996)) #### Build & Tooling - ✨ Add artifacts to public s3 bucket ([#8947](DataDog/dd-trace-java#8947) - [@randomanderson](https://github.com/randomanderson)) #### Continuous Integration Visibility - ✨ Improve PR information building ([#8908](DataDog/dd-trace-java#8908) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Truncate span stack traces when Test Optimization is enabled ([#8903](DataDog/dd-trace-java#8903) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Ensure auto-detected service name is the same for every process in the same build ([#8902](DataDog/dd-trace-java#8902) - [@nikita-tkachenko-datadog](https://github.com/nikita-tkachenko-datadog)) - 🐛 Use tag as fallback in api requests if no branch is available ([#8876](DataDog/dd-trace-java#8876) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add support for JUnit 5.13-RC1 ([#8865](DataDog/dd-trace-java#8865), [#8871](DataDog/dd-trace-java#8871) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Implement attempt to fix v3 and v4 and bump capability version ([#8824](DataDog/dd-trace-java#8824) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🧹 Align retry logic for all test framework instrumentations ([#8803](DataDog/dd-trace-java#8803) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - 🐛 Always build ci workspace without trailing separator ([#8788](DataDog/dd-trace-java#8788) - [@daniel-mohedano](https://github.com/daniel-mohedano)) - ✨ Add commit discrepancies telemetry when building repository git information ([#8763](DataDog/dd-trace-java#8763) - [@daniel-mohedano](https://github.com/daniel-mohedano)) #### Data Streams Monitoring - 💡 Surface process tags in dsm payloads and use them for base hash calculation ([#8836](DataDog/dd-trace-java#8836) - [@amarziali](https://github.com/amarziali)) #### Dynamic Instrumentation - ✨ Optimized allocations for collection filter functions ([#8896](DataDog/dd-trace-java#8896) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix SymDB upload size check ([#8887](DataDog/dd-trace-java#8887) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for Set in filter function ([#8873](DataDog/dd-trace-java#8873) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Add support for isDefined in log template ([#8859](DataDog/dd-trace-java#8859) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Fix Max captured frames for Exception Replay ([#8856](DataDog/dd-trace-java#8856) - [@jpbempel](https://github.com/jpbempel)) - 🐛 Remove static inherited fields collection ([#8832](DataDog/dd-trace-java#8832) - [@jpbempel](https://github.com/jpbempel)) - 💡 Add process tags to dynamic instrumentation intake payload ([#8779](DataDog/dd-trace-java#8779) - [@amarziali](https://github.com/amarziali)) #### GraalVM native-image - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) - ✨ Add JMXFetch support for GraalVM Native ([#8569](DataDog/dd-trace-java#8569) - [@ygree](https://github.com/ygree)) #### JMX fetch - ✨ Add support for GraalVM Native GC metrics ([#8913](DataDog/dd-trace-java#8913) - [@ygree](https://github.com/ygree)) #### Library Injection - ✨ Deny oracle db jvm based tools ([#8909](DataDog/dd-trace-java#8909) - [@bric3](https://github.com/bric3)) #### OpenTracing - 🐛 Fix OT packaging for exception replay ([#8912](DataDog/dd-trace-java#8912) - [@jpbempel](https://github.com/jpbempel)) #### Profiling - ✨ Bump ddprof to 1.27.0 ([#8893](DataDog/dd-trace-java#8893) - [@jbachorik](https://github.com/jbachorik)) - Properly handle the adaptive sampling interval overflow by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#213 - Fix [#200](DataDog/dd-trace-java#200) Crash related to aligned\_alloc and free in context by [@yanglong1010](https://github.com/yanglong1010) in DataDog/java-profiler#208 - Explicitly initialize empty context page by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#210 - Re-connect crash recursion protection with VM stackwalker by [@jbachorik](https://github.com/jbachorik) in DataDog/java-profiler#214 - ✨ Enable ZSTD compression for profiling ([#8862](DataDog/dd-trace-java#8862) - [@MattAlp](https://github.com/MattAlp)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - 💡 Collect process tags for profiling upload requests ([#8780](DataDog/dd-trace-java#8780) - [@amarziali](https://github.com/amarziali)) #### Telemetry - 💡 Surface process tags on telemetry payloads ([#8837](DataDog/dd-trace-java#8837) - [@amarziali](https://github.com/amarziali)) #### Trace context propagation - ✨ Migrating all HttpClient Instrumentations to Inject Full Context ([#8826](DataDog/dd-trace-java#8826) - [@mhlidd](https://github.com/mhlidd)) - ✨ Migrating all HttpServer Instrumentations to Extract full Context ([#8820](DataDog/dd-trace-java#8820) - [@mhlidd](https://github.com/mhlidd)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer core - ✨⚡ Skip JAXB generated classes classloader ([#9003](DataDog/dd-trace-java#9003) - [@bric3](https://github.com/bric3)) - ✨ Add DD\_RUNTIME\_METRICS\_RUNTIME\_ID\_ENABLED alias for runtime id generation ([#8981](DataDog/dd-trace-java#8981) - [@amarziali](https://github.com/amarziali)) - 🐛 Use resolved address for peer.hostname when available without hitting the cache ([#8915](DataDog/dd-trace-java#8915) - [@amarziali](https://github.com/amarziali)) - 💡 Surface server name process tag for tomcat ([#8894](DataDog/dd-trace-java#8894) - [@amarziali](https://github.com/amarziali)) - 💡 Surface websphere cell and server name on process tags ([#8880](DataDog/dd-trace-java#8880) - [@amarziali](https://github.com/amarziali)) - ✨ Added special lightweight pre-main class that skips installation on incompatible JVMs. ([#8855](DataDog/dd-trace-java#8855) - [@AlexeyKuznetsov-DD](https://github.com/AlexeyKuznetsov-DD)) - 💡 Add entrypoint type to process tags ([#8839](DataDog/dd-trace-java#8839) - [@amarziali](https://github.com/amarziali)) - ✨ Extend JPS re-implementation to J9 family ([#8813](DataDog/dd-trace-java#8813) - [@MattAlp](https://github.com/MattAlp)) - ✨ Notify listeners when the scope top changes after switching scope stacks ([#8797](DataDog/dd-trace-java#8797) - [@mcculls](https://github.com/mcculls)) - ✨ Read hsperfdata for Java PIDs if jvmstat is unavailable ([#8792](DataDog/dd-trace-java#8792) - [@MattAlp](https://github.com/MattAlp)) - 🐛 Turn JDK socket support on by default ([#8752](DataDog/dd-trace-java#8752) - [@sarahchen6](https://github.com/sarahchen6)) - ✨ Simplify context propagation ([#8719](DataDog/dd-trace-java#8719) - [@PerfectSlayer](https://github.com/PerfectSlayer)) - ✨ Add JSON parsing support ([#8579](DataDog/dd-trace-java#8579) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Tracer internal logging - ✨ Fix printing format of span identifiers ([#8897](DataDog/dd-trace-java#8897) - [@vandonr](https://github.com/vandonr)) #### Tracer public API - 💡 Track the source of installation ([#8956](DataDog/dd-trace-java#8956) - [@mabdinur](https://github.com/mabdinur)) - ✨ Enforce size limit on application\_monitoring.yaml files ([#8789](DataDog/dd-trace-java#8789) - [@mtoffl01](https://github.com/mtoffl01)) - ✨ Enabling baggage cache to support limits and non-ascii characters ([#8713](DataDog/dd-trace-java#8713) - [@mhlidd](https://github.com/mhlidd)) ### Instrumentations #### AWS Lambda instrumentation - ✨ Pass Lambda Request ID to Extension ([#8814](DataDog/dd-trace-java#8814) - [@nhulston](https://github.com/nhulston)) #### Core Java language instrumentation - ✨ Ensure ClassloadingInstrumentation is always applied even with `DD_TRACE_ENABLED=false` ([#8863](DataDog/dd-trace-java#8863) - [@mcculls](https://github.com/mcculls)) #### Eclipse Vert.x instrumentation - 🐛 Do not override route with / in vertx instrumentation ([#8881](DataDog/dd-trace-java#8881) - [@vandonr](https://github.com/vandonr)) #### IBM Liberty - 🐛 Fix error mark on http status for IBM liberty ([#8822](DataDog/dd-trace-java#8822) - [@amarziali](https://github.com/amarziali)) #### JDBC instrumentation - 🐛 Do not prepend DBM <> APM trace comment in SQLCommenter if there is a pg plan hint ([#8864](DataDog/dd-trace-java#8864) - [@edengorevoy](https://github.com/edengorevoy)) #### JMS instrumentation - ✨ Add jms as an extra integration name where there is JMS involved ([#8933](DataDog/dd-trace-java#8933) - [@vandonr](https://github.com/vandonr)) #### Kotlin instrumentation - ✨ Enable kotlin\_coroutine integration by default ([#8848](DataDog/dd-trace-java#8848) - [@mcculls](https://github.com/mcculls)) - 🧹 Rework Kotlin coroutines instrumentation around coroutine context ([#8774](DataDog/dd-trace-java#8774) - [@mcculls](https://github.com/mcculls)) #### OpenTelemetry instrumentation - 🐛 Support WithSpan inheritContext attribute ([#8858](DataDog/dd-trace-java#8858) - [@amarziali](https://github.com/amarziali)) - ✨ Add context API support OTel propagators ([#8770](DataDog/dd-trace-java#8770) - [@PerfectSlayer](https://github.com/PerfectSlayer)) #### Play Framework instrumentation - 🐛 Fix the Play Framework's span resource name priority so that the client JAX-RS 404 cannot override it ([#8591](DataDog/dd-trace-java#8591) - [@ygree](https://github.com/ygree)) #### Quarkus Instrumentation - 🐛 Ignore quarkus jaxrs stubs and cdi wrapper proxies ([#8891](DataDog/dd-trace-java#8891) - [@amarziali](https://github.com/amarziali)) #### ServiceTalk - ✨ Improve ServiceTalk Captured Context API Instrumentation for v0.42.56+ ([#8821](DataDog/dd-trace-java#8821) - [@ygree](https://github.com/ygree)) #### Spring instrumentation - ✨ Supporting Baggage for Instrumentations used in Weblog Tests ([#8773](DataDog/dd-trace-java#8773) - [@mhlidd](https://github.com/mhlidd)) #### WebSocket Instrumentation - 💡 Trace websocket for spring webflux reactive handlers ([#8831](DataDog/dd-trace-java#8831) - [@amarziali](https://github.com/amarziali)) - 💡:test\_tube: WebSocket support for Netty ([#8632](DataDog/dd-trace-java#8632) - [@ValentinZakharov](https://github.com/ValentinZakharov)) #### Zio Instrumentation - 🧹 Cleanup Zio fiber instrumentation to avoid repeated activation of continuation ([#8798](DataDog/dd-trace-java#8798) - [@mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: 9207366cdb6a1bd098082305d354a0a3c4622d7a

enabling baggage cache to support limits

0ac63be

updating limits to consider non-ascii characters

eb3ae15

mhlidd changed the title ~~enabling baggage cache to support limits~~ Enabling baggage cache to support limits and non-ascii characters Apr 22, 2025

mhlidd marked this pull request as ready for review April 22, 2025 21:06

mhlidd requested a review from a team as a code owner April 22, 2025 21:06

mhlidd requested a review from ygree April 22, 2025 21:06

mhlidd added the comp: api Tracer public API label Apr 22, 2025

mhlidd added the type: feature Enhancements and improvements label Apr 22, 2025

mhlidd requested a review from PerfectSlayer April 22, 2025 21:49

mhlidd commented Apr 23, 2025

View reviewed changes

adding edge case

03d4b1c

PerfectSlayer reviewed Apr 29, 2025

View reviewed changes

PR comments

e111266

mhlidd requested a review from PerfectSlayer April 30, 2025 13:40

PerfectSlayer added 2 commits May 2, 2025 10:09

feat(core): Simplify baggage config usage

576aab8

feat(core): Add non ASCII character baggage extraction

f9c53d2

PerfectSlayer approved these changes May 2, 2025

View reviewed changes

Merge branch 'master' into mhlidd/update_baggage_limits

a1e5ffb

mhlidd merged commit a511d59 into master May 7, 2025

mhlidd deleted the mhlidd/update_baggage_limits branch May 7, 2025 14:25

github-actions Bot added this to the 1.50.0 milestone May 7, 2025

Sunbelt Computer Software

PL/B Language Development and Support

Conversation

mhlidd commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Does This Do

Motivation

Additional Notes

Contributor Checklist

Uh oh!

pr-commenter Bot commented Apr 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Benchmarks

Startup

Parameters

Summary

Load

Parameters

Summary

Dacapo

Parameters

Summary

Uh oh!

github-actions Bot commented Apr 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mhlidd Apr 23, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer commented Apr 24, 2025

Uh oh!

mhlidd commented Apr 24, 2025

Uh oh!

mhlidd commented Apr 25, 2025

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

mhlidd Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

mhlidd Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer Apr 29, 2025

Choose a reason for hiding this comment

Uh oh!

PerfectSlayer left a comment

Choose a reason for hiding this comment

Uh oh!

mhlidd commented May 2, 2025

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mhlidd commented Apr 21, 2025 •

edited

Loading

pr-commenter Bot commented Apr 21, 2025 •

edited

Loading

github-actions Bot commented Apr 22, 2025 •

edited

Loading