{{ message }}
Repository navigation
Add deeper tests for DDApi using ratpack as a mock http server. - #31
Merged
Merged
Conversation
See https://danhyun.github.io/2016-gr8confus-testing-ratpack-apps/ for more examples with this style of testing.
gpolaert
reviewed
Jul 4, 2017
gpolaert
left a comment
gpolaert
left a comment
Contributor
There was a problem hiding this comment.
Tests are fine.
Just question about groovy tests, Should we use groovy?
My concerns are about mixing syntaxes, learning curve and maintenance in the long term.
I think we have to be sure using groove is a huge plus for the project. Otherwise, I think we should have keep only one syntax.
It's just my opinion. Tyler, you will(are ;) ) the lead, so it's your call.
Contributor
There was a problem hiding this comment.
Definitively a great idea :)
Contributor
Author
This was referenced May 20, 2025
Merged
This was referenced Jun 26, 2025
Closed
Closed
Closed
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See https://danhyun.github.io/2016-gr8confus-testing-ratpack-apps/ for more examples with this style of testing.
For more details about spock, see here: http://spockframework.org/spock/docs/1.0/spock_primer.html