{{ message }}
Fix CI typecheck cache invalidation#444
Merged
Merged
Conversation
Contributor
Author
Patch @jridgewell/remapping's invalid CJS declaration so TypeScript can parse it when CI resolves the package through the default export condition. Include all build tooling sources in the build cache key so generated dist artifacts are refreshed when declaration bundling code changes.
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: queued
mergequeue-status: in_progress
and removed
mergequeue-status: queued
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Fixes CI typecheck failures caused by TypeScript parsing
@jridgewell/remapping's invalid CJS declaration when cached generated build artifacts make the package resolve through the default export condition.Example failure: https://github.com/DataDog/build-plugins/actions/runs/28236150739/job/84499949413
Also broadens the CI build cache key so generated
distartifacts are invalidated when any build tooling source changes, not onlyrollupConfig.mjs.How?
Adds a Yarn patch for
@jridgewell/remapping@2.3.5that rewrites the invalidexport = function remapping(...)declaration into the standarddeclare function remapping(...); export = remapping;form.Updates CI cache
hashFilesinputs frompackages/tools/src/rollupConfig.mjstopackages/tools/src/**for the plugin build caches.