{{ message }}
[APPS] Use app host for OAuth authorization#436
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit intoJun 24, 2026
Merged
Conversation
Collaborator
Author
sdkennedy2
changed the title
Collaborator
Author
sdkennedy2
changed the title
ksun154
approved these changes
Jun 24, 2026
srosenthal-dd
approved these changes
Jun 24, 2026
srosenthal-dd
left a comment
srosenthal-dd
left a comment
Member
There was a problem hiding this comment.
not sure it makes a difference, but seems safe enough to try!
sdkennedy2
force-pushed
the
sdkennedy2/apps-oauth-authorize-app-host
branch
from
b6c50b9 to
ae4e9f7
Compare
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
sdkennedy2/apps-oauth-authorize-app-host
branch
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Apps upload OAuth currently builds the browser authorization URL on
https://api.<site>/oauth2/v1/authorize. Datadog OAuth docs and other internal clients use the app host for browser authorization and the api host for token exchange. In the wrong-org upload investigation, this is one suspicious difference in our OAuth client flow.Changes
Split the derived Datadog OAuth endpoints so browser authorization uses
https://app.<site>/oauth2/v1/authorize, while the token exchange continues to usehttps://api.<site>/oauth2/v1/token.This PR is intentionally narrow. It does not include token persistence changes or org-selection validation.
QA Instructions
Run an Apps upload that uses OAuth and confirm the browser opens the Datadog OAuth authorization flow on the
apphost.Blast Radius
This affects Apps upload OAuth flows that rely on the default Datadog OAuth configuration. API key upload flows and callers that provide a custom OAuth config are unchanged.
Documentation