{{ message }}
Keep live-debugger test helpers out of shipped code#408
Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits intoJun 12, 2026
Merged
Conversation
Move the transform syntax validation helper into the test file that uses it so it is no longer exported from the shipped transform module. Also make the optional peer dependency loader private now that its behavior is covered through the transform path rather than direct test access.
Contributor
Author
thenukasiva
approved these changes
Jun 12, 2026
tylfin
approved these changes
Jun 12, 2026
gh-worker-dd-mergequeue-cf854d
Bot
deleted the
watson/move-test-only-code-to-tests
branch
gh-worker-dd-devflow-36fce6
Bot
added
mergequeue-status: done
and removed
mergequeue-status: in_progress
labels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why?
Keep live-debugger test-only helpers out of the shipped transform module. The syntax validation helper is only used by transform unit tests, and the optional peer dependency loader no longer needs to be exported for direct test access.
How?
Moved
validateSyntaxintopackages/plugins/live-debugger/src/transform/index.test.tsand imported@babel/parserthere directly. MaderequireOptionalPeerDepprivate inpackages/plugins/live-debugger/src/transform/index.tswhile preserving the same runtime behavior throughtransformCode.Validated with
yarn test:unit packages/plugins/live-debugger/src/transform/index.test.ts.