{{ message }}
Align action buttons in footer with stepper navigation#751
Open
Irozuku wants to merge 2 commits into
Open
Conversation
Move the Set column and help buttons into the same row as the stepper navigation footer, sharing one top border and baseline. Add an sx passthrough on FormSchemaButtonGroup so the footer border/padding can be neutralized when composed with other controls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reorganizes the converter scope step so the "Set column", help, and Next buttons live in one aligned footer row, and makes
FormSchemaButtonGroupcomposable via ansxprop.Previously the "Set column" trigger and its help tooltip sat in a separate row above the stepper footer. The footer also carried its own top border and padding, so when combined the two groups had mismatched heights and the border only spanned part of the width. This unifies them into a single row with one shared top border and a common baseline.
Type of Change
Check all that apply like this [x]:
Changes (by file)
ScopeStepConverter.jsxalignItems: center,gap,flexGrowon the footer so Next stays right-aligned).FormSchemaButtonGroup.jsxsxprop, forwarded to the underlyingStepperNavigationFooter, so callers can override the footer's default border/padding when composing it with other controls.propTypes.ConverterTargetColumnModal.jsx