Ruby gem overmind#176
Conversation
There was a problem hiding this comment.
What is the purpose of this notice file? Why we need it?
There was a problem hiding this comment.
Let's keep it in sync with overmind itself!
| VERSION = "0.1.2" | |
| VERSION = "2.4.0" |
| # Class for downloading Overmind binaries. | ||
| class OvermindDownloader < BaseDownloader | ||
| NAME = "overmind" | ||
| DEFAULT_VERSION = "2.4.0" |
There was a problem hiding this comment.
Let's use here gem version also (if we keep it in sync with overmind one)
| DEFAULT_VERSION = "2.4.0" | |
| DEFAULT_VERSION = ::Overmind::VERSION |
There was a problem hiding this comment.
Missing steps to build tmux and what are pre-requisites (having Overmind itself already released on GitHub, right?)
There was a problem hiding this comment.
thanks, I added to RELEASING.md
There was a problem hiding this comment.
Do we need a separate changelog?
There was a problem hiding this comment.
If we want to always use bundled tmux, its path should be prepended, not appended
There was a problem hiding this comment.
thanks, fixed!
There was a problem hiding this comment.
I believe this should be located in packaging/rubygems and should be included in the gem. Also, it should contain licenses of tmux deps
3 participants
This PR adds the ability to generate gem files that pack the
overmindlibrary with dependenciestmuxinto a gem file for various architectures of theLinuxandmacosplatforms by running a rake taskovermind:build:all.It also prepares the gem file for
FreeBSD, but withouttmuxin the boxThe rake task will download the overmind and tmux binaries and package them into a platform-specific gem.
To build the gem files, you need to have
Ruby >= 3.0.This PR also adds a
NOTICEfile and additional information to the README.md.