{{ message }}
Repository navigation
docs: correct completion caret and result ranges - #496
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
liuxy0551
approved these changes
Oct 21, 2026
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

The English and Chinese README examples disagree with the current public FlinkSQL API:
null; usesql.length + 1to obtain the listed keywords.getAllEntitiesinstead ofgetSuggestionAtCaretPosition.endIndex/endColumn, with the showntbrange ending at column 17.Only the two README files change. Parser implementations, grammars and generated files are unchanged.
Validation on Linux, Node 20.19.5 and pnpm 9.7.0 with the frozen lockfile:
pnpm prettier-check,pnpm check-types,pnpm antlr4 --all --check, andpnpm buildpassed on the unchanged implementation.pnpm run test --runInBand: 224 suites / 6,523 tests passed on that same implementation.git diff --checkverified.Node 18 and hosted CI were not run locally.