{{ message }}
[Port dspace-7_x] Escape html tags in innerHTML #4737#4881
Merged
Conversation
…rough an innerHTML attribute or not to properly escape them
…rt-4737-to-dspace-7_x
tdonohue
added
bug
high priority
component: Item
tdonohue
requested changes
Dec 3, 2025
tdonohue
left a comment
tdonohue
left a comment
Member
There was a problem hiding this comment.
@bram-maegerman : Thanks for this backport. I tested it today and it's mostly working well. However, I found what looks to be a few mistakes in the MyDSpace results list. Both the abstract field and the date field are not being escaped properly. So, there's a few lines of code that I believe are missing from #4737. But, please double check my analysis and try it on your end.
See inline notes below.
github-project-automation
Bot
moved this to 👀 Under Review
in DSpace Maintenance (10.x, 9.x, 8.x)
Contributor
Author
tdonohue
approved these changes
Dec 8, 2025
tdonohue
left a comment
tdonohue
left a comment
Member
There was a problem hiding this comment.
👍 Thanks @bram-maegerman ! I retested / re-reviewed this today and it's now working properly and has the same behavior as #4737
github-project-automation
Bot
moved this from 👀 Under Review
to 👍 Reviewer Approved
in DSpace Maintenance (10.x, 9.x, 8.x)
github-project-automation
Bot
moved this from 👍 Reviewer Approved
to ✅ Done
in DSpace Maintenance (10.x, 9.x, 8.x)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port of #4737 by @bram-maegerman to
dspace-7_x