[Port dspace-7_x] Removed observable function calls from template (part 2) by alexandrevryghem · Pull Request #4488 · DSpace/dspace-angular · GitHub
Skip to content

[Port dspace-7_x] Removed observable function calls from template (part 2)#4488

Merged
tdonohue merged 5 commits into
DSpace:dspace-7_xfrom
alexandrevryghem:w2p-117573_remove-observable-function-calls-from-template-7_x
Jun 26, 2025
Merged

[Port dspace-7_x] Removed observable function calls from template (part 2)#4488
tdonohue merged 5 commits into
DSpace:dspace-7_xfrom
alexandrevryghem:w2p-117573_remove-observable-function-calls-from-template-7_x

Conversation

@alexandrevryghem

Copy link
Copy Markdown
Member

Port of #4290 & #4304 to dspace-7_x.

- The unthemed home news didn't stick to the header like the dspace theme
- Impersonate user button has additional margin
- Submission form loading icon is not translatable
- Create resource policy page doesn't have the correct heading

(cherry picked from commit 56e45a9)
@alexandrevryghem alexandrevryghem added this to the 7.6.4 milestone Jun 20, 2025
@alexandrevryghem alexandrevryghem self-assigned this Jun 20, 2025
@alexandrevryghem alexandrevryghem added bug performance / caching Related to performance, caching or embedded objects labels Jun 20, 2025
@alexandrevryghem alexandrevryghem moved this to 🙋 Needs Reviewers Assigned in DSpace Maintenance (10.x, 9.x, 8.x) Jun 20, 2025
@tdonohue tdonohue self-requested a review June 23, 2025 15:30

@tdonohue tdonohue left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alexandrevryghem ! I gave this a manual test today, and everything looks good.

@github-project-automation github-project-automation Bot moved this from 🙋 Needs Reviewers Assigned to 👍 Reviewer Approved in DSpace Maintenance (10.x, 9.x, 8.x) Jun 26, 2025
@tdonohue tdonohue merged commit cf2407b into DSpace:dspace-7_x Jun 26, 2025
15 checks passed
@github-project-automation github-project-automation Bot moved this from 👍 Reviewer Approved to ✅ Done in DSpace Maintenance (10.x, 9.x, 8.x) Jun 26, 2025
@alexandrevryghem alexandrevryghem deleted the w2p-117573_remove-observable-function-calls-from-template-7_x branch June 27, 2025 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug performance / caching Related to performance, caching or embedded objects

Projects

Development

Successfully merging this pull request may close these issues.

2 participants