{{ message }}
fix JSON schema issues found by AJV - #230
Merged
stevespringett merged 14 commits intoMay 29, 2023
Merged
Conversation
Member
Author
jkowalleck
changed the title
jkowalleck
force-pushed
the
v1.5-schemaParser-AJV
branch
from
May 25, 2023 12:28
9bb29dc to
26672e5
Compare
jkowalleck
changed the title
jkowalleck
marked this pull request as ready for review
May 25, 2023 14:17
jkowalleck
force-pushed
the
v1.5-schemaParser-AJV
branch
2 times, most recently
from
May 25, 2023 14:38
fe98ac0 to
7180c8a
Compare
jkowalleck
marked this pull request as draft
May 26, 2023 12:21
jkowalleck
force-pushed
the
v1.5-schemaParser-AJV
branch
from
May 26, 2023 12:38
8c2e557 to
8e31f41
Compare
jkowalleck
marked this pull request as ready for review
May 26, 2023 12:38
jkowalleck
force-pushed
the
v1.5-schemaParser-AJV
branch
from
May 26, 2023 12:43
b47636e to
f9813f7
Compare
jkowalleck
marked this pull request as draft
May 26, 2023 12:56
jkowalleck
marked this pull request as ready for review
May 26, 2023 13:26
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jkowalleck
force-pushed
the
v1.5-schemaParser-AJV
branch
from
May 28, 2023 10:04
d750f5c to
d7f689e
Compare
Member
Author
stevespringett
approved these changes
May 29, 2023
jkowalleck
added a commit
that referenced
this pull request
Jun 16, 2023
* remove `additionalItems` for non-array-`items` see also #230 Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
jvdsn
pushed a commit
to jvdsn/specification
that referenced
this pull request
Feb 23, 2026
fix JSON schema issues found by AJV
jvdsn
pushed a commit
to jvdsn/specification
that referenced
this pull request
Feb 23, 2026
* remove `additionalItems` for non-array-`items` see also CycloneDX#230 Signed-off-by: Jan Kowalleck <jan.kowalleck@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #208
additionalItems: it is to be used, ifitemsis a defined list -> to be treated as a tuple. see https://datatracker.ietf.org/doc/html/draft-handrews-json-schema-02#section-9.3.1.2Then,
additionalItems:falsemean, that no more than the number of defined items is to be allowed in this tuple.Removed all to-be-ignored
additionalItemswhereitemswas not a list but a type-def.In contrast, here is a correct usage of
additionalItems-> https://github.com/CycloneDX/specification/pull/205/files#r1205400111type:objectwhere it was missing