{{ message }}
Wilson K values: use exact coefficient#2746
Open
longemen3000 wants to merge 1 commit into
Open
Conversation
Contributor
Contributor
|
Ping @longemen3000 . Still interested in this one? |
Contributor
Author
|
Sorry, I did not see the notification 😅, I will add some descriptions in the files, but if the LLM does it, that would also be good |
Contributor
Author
|
If you are interested in a better correlation for the initial point of the VLE 2-phase PT flash, the algorithm that I use is a combination of:
|
Contributor
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
somewhat related to #2742. The Wilson K-value correlation is actually a linear interpolation between ($0.7T_c$ , $P(0.7T_c$ ) and ($T_c$ , $P_c$ ) in ($T^{-1}$ , $\log{p}$ ) coordinates. with that in mind, the more precise correlation is: