{{ message }}
Download COS kernel archive at specified commit#13
Open
Amey-D wants to merge 1 commit into
Open
Conversation
Instead of `git pull`ing the sources this PR utilizes gitiles' feature to download the source tarball at the specified commit. This also removes `git clone` from the Dockerfile.
rohitagarwal003
left a comment
rohitagarwal003
left a comment
Contributor
There was a problem hiding this comment.
$ time curl -sS "${download_url}" -o "${archive_filename}"
real 1m10.413s
user 0m0.829s
sys 0m1.958s
$ time tar xf "${archive_filename}"
real 0m9.957s
user 0m2.494s
sys 0m7.319s
I don't think this added latency on node bring up is going to work.
Contributor
There was a problem hiding this comment.
I tried this command without setting LAKITA_KERNEL_SHA and it still passed.
Contributor
Author
|
Is there a way we can measure e2e latency on GCE? Presumably with this PR the Docker container would also become smaller so |
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of
git pulling the sources this PR utilizes gitiles' featureto download the source tarball at the specified commit. This also
removes
git clonefrom the Dockerfile.