feat: Speedup all the ldap stuff by BigSpaceships · Pull Request #581 · ComputerScienceHouse/conditional · GitHub
Skip to content

feat: Speedup all the ldap stuff#581

Merged
aln730 merged 10 commits into
developfrom
speedup-ldap
Jun 26, 2026
Merged

feat: Speedup all the ldap stuff#581
aln730 merged 10 commits into
developfrom
speedup-ldap

Conversation

@BigSpaceships

Copy link
Copy Markdown
Contributor

What

replaces csh_ldap functions with csh_ldap.get_group_attributes to make only one ldap query instead of n+3

Why

speeeed

Test Plan

locally looked at all the pages and everyone showed up right

Env Vars

nope

Documentation

NA

Checklist

  • Tested all changes locally

@datadog-computersciencehouse

Copy link
Copy Markdown

@csh-sonarqube-community

Copy link
Copy Markdown

@aln730 aln730 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aln730 aln730 merged commit f1f530d into develop Jun 26, 2026
4 checks passed
@BigSpaceships BigSpaceships deleted the speedup-ldap branch June 27, 2026 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants