{{ message }}
Repository navigation
Improve handling of coverage exclude option on PHPUnit 11+ - #6937
Merged
Merged
Conversation
Create the difference list based on the real file paths to account for platform specific handling (such as Windows sometimes using \ instead of / ) or relative path differences
TavoNiievez
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

In #6739 the
excludeoption for running coverage on PHPUnit11+ was reimplemented by @NaktibaldaThe alternative implementation (
function newWhiteList()) creates a regression when running on Windows with a config like:The
array_diff()compares files between both file lists based on string paths which may not use exactly the same formatting. In the case above, files inbarare not excluded because when comparing paths they partially contain\instead of/as a directory separator.This PR improves the compare function looking at normalized real paths.