I just tried throwing an \Error in the try block (because that would be caught with your change, but not without) and codeception exited with a code 255 and the output contained a stack trace for Uncaught Error. No test was executed, but codeception also didn't exit with code 0 for me.

Applying your change makes codeception exit with a code of 1 and it does list all the tests as failing.

So the change looks ok to me, but I couldn't reproduce your issue with codeception exiting with code 0 in this case.

my error was: Call to a member function foo() on null
this was in one of the observers
maybe that help reproducing it

I tried it with

$foo = null;
$foo->foo();

in the try block and got

PHP Fatal error: Uncaught Error: Call to a member function foo() on null

but still got exit code 255.

I don't think this is a blocker for this PR though.

I'm okay with this change, but I'm not sure it's the only place where it should be made.

Not sure if it's the only place. It's the place I've had a problem with.
Is this going to be approved?

I'm okay with this change, but I'm not sure it's the only place where it should be made.

@TavoNiievez I'm also not 100% sure if there are other places. But the current state is already an improvement and thus it would be great to get it merged.