PHP 8.5: Avoid accessing deprecated $http_response_header by W0rma · Pull Request #6924 · Codeception/Codeception · GitHub
Skip to content

PHP 8.5: Avoid accessing deprecated $http_response_header - #6924

Merged
TavoNiievez merged 1 commit into
Codeception:mainfrom
W0rma:fix-http-response-header
Feb 18, 2026
Merged

TavoNiievez merged 1 commit into
Codeception:mainfrom
W0rma:fix-http-response-header

Conversation

@W0rma

@W0rma W0rma commented Jan 29, 2026

Copy link
Copy Markdown
Contributor

Follow-up of #6919

The current check does still trigger a deprecation warning in PHP 8.5.

This is fixed by using the check as suggested in https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_the_http_response_header_predefined_variable

…ast_response_headers() exists

Otherwise, PHP triggers a deprecated warning in PHP 8.5.
@W0rma
W0rma marked this pull request as ready for review January 29, 2026 07:05
@W0rma

W0rma commented Jan 29, 2026

Copy link
Copy Markdown
Contributor Author

@W0rma W0rma mentioned this pull request Feb 7, 2026

@TavoNiievez TavoNiievez left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@TavoNiievez
TavoNiievez merged commit b5fd111 into Codeception:main Feb 18, 2026
10 checks passed
@W0rma
W0rma deleted the fix-http-response-header branch February 18, 2026 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants