Added the `CLICKHOUSE_CPP_` prefix for all cmake build options. by german3w1 · Pull Request #360 · ClickHouse/clickhouse-cpp · GitHub
Skip to content

Added the CLICKHOUSE_CPP_ prefix for all cmake build options.#360

Merged
Enmk merged 2 commits into
ClickHouse:3.0from
german3w1:build_options_prefix
Feb 20, 2024
Merged

Added the CLICKHOUSE_CPP_ prefix for all cmake build options.#360
Enmk merged 2 commits into
ClickHouse:3.0from
german3w1:build_options_prefix

Conversation

@german3w1

Copy link
Copy Markdown
Contributor

For version 3.0

@Enmk Enmk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please change base branch from master to 3.0 ?

@german3w1 german3w1 marked this pull request as draft February 15, 2024 20:58
@german3w1 german3w1 changed the base branch from master to 3.0 February 15, 2024 20:58
@german3w1 german3w1 marked this pull request as ready for review February 15, 2024 21:00
@german3w1

Copy link
Copy Markdown
Contributor Author

@Enmk Enmk left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Enmk Enmk merged commit db36d10 into ClickHouse:3.0 Feb 20, 2024
@german3w1 german3w1 deleted the build_options_prefix branch February 28, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants