{{ message }}
Remove stop_words param for unicode tokenizer#99834
Merged
george-larionov merged 3 commits intoMar 19, 2026
Merged
Conversation
Contributor
clickhouse-gh
Bot
added
the
pr-not-for-changelog
Member
Author
george-larionov
changed the title
![clickhouse-gh[bot]](https://avatars.githubusercontent.com/in/928874?s=60&v=4){kind=small}
rschu1ze
reviewed
Mar 18, 2026
rschu1ze
approved these changes
Mar 18, 2026
rschu1ze
changed the title
stop_words param for unicode tokenizer
Member
rschu1ze
reviewed
Mar 19, 2026
| if (escaped) | ||
| { | ||
| --pos; | ||
| escaped = false; |
Member
There was a problem hiding this comment.
Are you sure it's safe to delete l. 663?
Member
Author
There was a problem hiding this comment.
yes, escaped is local to the function, it was updated here because it was used a few lines later for a stop-words specific bit of logic. However now that code is gone and this line can be dropped safely because right after we return from the function.
The only potential issue is that whoever adds the stop_words functionality back in needs to add this line back in as well, but if they just revert all the changes in this PR it should be fine.
Contributor
LLVM Coverage ReportPR changed lines: PR changed-lines coverage: 96.23% (51/53, 0 noise lines excluded) |
george-larionov
deleted the
remove-stop-words-param-from-unicode-tokenizer
branch
robot-ch-test-poll2
added
the
pr-synced-to-cloud
george-larionov
pushed a commit
to amosbird/ClickHouse
that referenced
this pull request
Mar 20, 2026
…stop words removal Revert accidental submodule pointer changes for libstemmer_c, NuRaft, and rust_vendor that leaked in during rebase. Update test references to reflect that stop words were removed from unicodeWord tokenizer by PR ClickHouse#99834: fullwidth comma is now returned as a token, and the stop-words-as-argument test case is removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removing stop words parameter of unicode tokenizer. It was decided that we should add it back in as a index-level parameter later. See the PR where it was added: #99357
Changelog category (leave one):
Documentation entry for user-facing changes