Skip to content
Navigation Menu
{{ message }}
-
Notifications
You must be signed in to change notification settings - Fork 8.6k
Support per-element aggregation of Tuple columns in SummingMergeTree, AggregatingMergeTree and CoalescingMergeTree
#98039
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
nihalzp
merged 53 commits into
ClickHouse:master
from
JingYanchao:johnjing/subcolumn-aggregate-tuple
Jun 11, 2026
Merged
Changes from all commits
Commits
Show all changes
53 commits
Select commit
Hold shift + click to select a range
bf9176f
support tuple element aggregation and summing
JingYanchao 71792f7
fix review issue
JingYanchao 62f19c9
Merge branch 'master' into johnjing/subcolumn-aggregate-tuple
nihalzp 4472dfe
Merge branch 'master' into johnjing/subcolumn-aggregate-tuple
nihalzp 09343c1
Move setting to 26.4
nihalzp 896a2f7
Merge branch 'master' into johnjing/subcolumn-aggregate-tuple
alexey-milovidov 1d1341b
fix summing merge tree aggregate bug
JingYanchao 63b5306
fix code spaces
JingYanchao 7673c6e
fix review
JingYanchao 1da139e
Merge branch 'master'
JingYanchao e4bfd12
validate flatten columns for summing sorted algorithm
JingYanchao 2cc77c5
Merge branch 'master' into johnjing/subcolumn-aggregate-tuple
nihalzp 9c29926
Move setting to 26.5
nihalzp 83408eb
fix review bug & set allow_tuple_element_aggregation = true
JingYanchao 32d0f7d
fix review test cases
JingYanchao a00aa41
Merge branch 'master'
JingYanchao 33ae316
fix test cases bug
JingYanchao b10b600
fix test cases
JingYanchao 1c52a4b
fix test cases
JingYanchao 8fdbac7
Merge branch 'master' into johnjing/subcolumn-aggregate-tuple
JingYanchao d4f296a
fix test cases
JingYanchao eb00361
Merge branch 'master' into johnjing/subcolumn-aggregate-tuple
nihalzp 3bd2c93
Move setting to 26.6
nihalzp 292cd82
Remove from 26.5
nihalzp 0c67143
Turn off the setting by default
nihalzp 5af94d4
Make the setting false by default
nihalzp ced0505
Skip `Nullable(Tuple)`
nihalzp 4ccca2a
Refactor utils in NestedUtils
nihalzp 084e117
Improve `isColumnOrAncestorInNames`
nihalzp 79e6b90
Fix *Map being incorrectly summed
nihalzp 4591855
Remove special handling of *Map in `CoalescingMergeTree` that caused …
nihalzp 790212e
Add test for the crash
nihalzp 0aac4af
Use helper in `containsNullableFlattenableTuple`
nihalzp 6fdf422
Add test to make sure setting is disabled by default
nihalzp 6a4da46
Remove `countFlattenedColumnsRecursive`
nihalzp 856e96f
Add test to reject Nullable(Tuple)
nihalzp 052a4db
Add test for subcolumns names with dot
nihalzp 9f3d2e9
Add test for name collision
nihalzp adebe6b
Increase test coverage
nihalzp 3f31619
Improve `03802_tuple_element_aggregation_settings_validation.sh`
nihalzp 0d54cca
Update example formatting
nihalzp 4a11e18
Fix edge case
nihalzp 93a4f34
Add test for the fix
nihalzp 99bd8b7
Skip sub columns that are in the sorting or partition key
nihalzp 830990b
Add test for skipping sorting and partition key
nihalzp 9ddb333
Add utility to reject columns with same leaf name `flattenTupleLeafNa…
nihalzp 30b04dc
Add test for the case
nihalzp 3613962
Reject duplicate subcolumn name
nihalzp 988f4e6
Check constraint during ALTER as well
nihalzp 696d52a
Add test for ALTER validation
nihalzp dbc7757
Update test
nihalzp 7570ee6
Rerun CI
nihalzp fe61ffb
Merge branch 'master' into johnjing/subcolumn-aggregate-tuple
nihalzp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
You can’t perform that action at this time.

Uh oh!
There was an error while loading. Please reload this page.