Validate witness version in bech32 to avoid buffer overflow by Algunenano · Pull Request #96671 · ClickHouse/ClickHouse · GitHub
Skip to content

Validate witness version in bech32 to avoid buffer overflow#96671

Merged
Algunenano merged 2 commits into
ClickHouse:masterfrom
Algunenano:bech32_witness
Feb 11, 2026
Merged

Validate witness version in bech32 to avoid buffer overflow#96671
Algunenano merged 2 commits into
ClickHouse:masterfrom
Algunenano:bech32_witness

Conversation

@Algunenano

@Algunenano Algunenano commented Feb 11, 2026 •
edited by robot-ch-test-poll
Loading

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC) or LOGICAL_ERROR

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Validate witness version in bech32 to avoid buffer overflow

Fix #96668

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Version info

  • Merged into: 26.2.1.593
  • Backported to: 26.1.3.33, 25.12.6.24, 25.11.9.31, 25.8.17.17

@clickhouse-gh

clickhouse-gh Bot commented Feb 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@clickhouse-gh clickhouse-gh Bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Feb 11, 2026
@ahmadov ahmadov self-assigned this Feb 11, 2026
@Algunenano Algunenano added this pull request to the merge queue Feb 11, 2026
Merged via the queue into ClickHouse:master with commit eb2df3f Feb 11, 2026
134 checks passed
@Algunenano Algunenano deleted the bech32_witness branch February 11, 2026 19:05
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Feb 11, 2026
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Feb 11, 2026
This was referenced Feb 11, 2026
Closed
Merged
robot-clickhouse added a commit that referenced this pull request Feb 11, 2026
@robot-clickhouse
Backport #96671 to 25.8: Validate witness version in bech32 to avoid …
b840f86 
…buffer overflow
This was referenced Feb 11, 2026
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Feb 11, 2026
@robot-clickhouse
Backport #96671 to 25.11: Validate witness version in bech32 to avoid…
7f207b8 
… buffer overflow
This was referenced Feb 11, 2026
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Feb 11, 2026
@robot-clickhouse
Backport #96671 to 25.12: Validate witness version in bech32 to avoid…
8320c98 
… buffer overflow
This was referenced Feb 11, 2026
Merged
Merged
robot-clickhouse added a commit that referenced this pull request Feb 11, 2026
@robot-clickhouse
Backport #96671 to 26.1: Validate witness version in bech32 to avoid …
d1d8288 
…buffer overflow
@robot-ch-test-poll3 robot-ch-test-poll3 mentioned this pull request Feb 11, 2026
Merged
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Feb 11, 2026
clickhouse-gh Bot added a commit that referenced this pull request Feb 11, 2026
@clickhouse-gh
Merge pull request #96689 from ClickHouse/backport/25.8/96671
7a0c7c7 
Backport #96671 to 25.8: Validate witness version in bech32 to avoid buffer overflow
Algunenano added a commit that referenced this pull request Feb 12, 2026
@Algunenano
Merge pull request #96693 from ClickHouse/backport/25.12/96671
616dee8 
Backport #96671 to 25.12: Validate witness version in bech32 to avoid buffer overflow
Algunenano added a commit that referenced this pull request Feb 12, 2026
@Algunenano
Merge pull request #96695 from ClickHouse/backport/26.1/96671
cc8e631 
Backport #96671 to 26.1: Validate witness version in bech32 to avoid buffer overflow
Algunenano added a commit that referenced this pull request Feb 12, 2026
@Algunenano
Merge pull request #96691 from ClickHouse/backport/25.11/96671
e8287d8 
Backport #96671 to 25.11: Validate witness version in bech32 to avoid buffer overflow
@clickgapai clickgapai mentioned this pull request Apr 27, 2026
Merged
@robot-ch-test-poll robot-ch-test-poll mentioned this pull request Jun 30, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahmadov ahmadov ahmadov approved these changes

Assignees

@ahmadov ahmadov

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

AddressSanitizer (STID: 3868-5f4b) in bech32Encode

5 participants

@Algunenano @ahmadov @robot-ch-test-poll4 @robot-ch-test-poll3 @robot-clickhouse-ci-2