{{ message }}
Fix flaky test 01079_parallel_alter_detach_table_zookeeper#94752
Closed
samay-sharma wants to merge 2 commits into
Closed
Fix flaky test 01079_parallel_alter_detach_table_zookeeper#94752samay-sharma wants to merge 2 commits into
samay-sharma wants to merge 2 commits into
Conversation
Previously, the code would continue to loop until the command stopped producing output (i.e. succeeded). This worked for transient failures. However, in cases where this command continuously fails due to a previous failure (eg. failed CREATE TABLE), this test would just hang instead of failing gracefully. The loop is now bounded to have only 3 retries.
Contributor
Member
|
@samay-sharma, something else needed here. |
Member
Author
|
Yes, will look. |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Fixes #91413
All the test failures I observed fail due to TIMEOUT_EXCEEDED due to
distributed_ddl_task_timeoutduringDROP TABLE. I've modified the lines runningDROP TABLEto ignoreTIMEOUT_EXCEEDEDerrors. In all the example the test failures, the final output matches indicating no issues with the test run itself.Example failures:
[[1]](https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=88383&sha=aceb3e0e20aea76f3a95dfb92c4213fb7eaa7adb&name_0=PR&name_1=Stateless+tests+%28amd_binary%2C+old+analyzer%2C+s3+storage%2C+DatabaseReplicated%2C+sequential%29&name_1=Stateless+tests+%28amd_binary%2C+old+analyzer%2C+s3+storage%2C+DatabaseReplicated%2C+sequential%29&name_2=Tests
#88383), [[2]](https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=88490&sha=c627b0c7f0c609119caf233a4b89a1bfa3919364&name_0=PR&name_1=Stateless%20tests%20%28amd_binary%2C%20old%20analyzer%2C%20s3%20storage%2C%20DatabaseReplicated%2C%20sequential%29&name_1=Stateless%20tests%20%28amd_binary%2C%20old%20analyzer%2C%20s3%20storage%2C%20DatabaseReplicated%2C%20sequential%29
#88490), [[3]](https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=88827&sha=df34d890cffbf1de8b664ba1ab66d896b7de1ab6&name_0=PR&name_1=Stateless%20tests%20%28amd_binary%2C%20old%20analyzer%2C%20s3%20storage%2C%20DatabaseReplicated%2C%20sequential%29&name_1=Stateless%20tests%20%28amd_binary%2C%20old%20analyzer%2C%20s3%20storage%2C%20DatabaseReplicated%2C%20sequential%29
#88827), [[4]](https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=89367&sha=05881f0516f7bfb8fcdc62f0833c0fb22213ba96&name_0=PR&name_1=Stateless%20tests%20%28amd_binary%2C%20old%20analyzer%2C%20s3%20storage%2C%20DatabaseReplicated%2C%20sequential%29&name_1=Stateless%20tests%20%28amd_binary%2C%20old%20analyzer%2C%20s3%20storage%2C%20DatabaseReplicated%2C%20sequential%29
#89367), [[5]](https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=88269&sha=0a53cf04e9436bc4c109ef4766044df5aef6c21e&name_0=PR&name_1=Stateless%20tests%20%28amd_binary%2C%20old%20analyzer%2C%20s3%20storage%2C%20DatabaseReplicated%2C%20sequential%29&name_1=Stateless%20tests%20%28amd_binary%2C%20old%20analyzer%2C%20s3%20storage%2C%20DatabaseReplicated%2C%20sequential%29
#88269)
Also, while running the test locally, due to a faulty setup, my test was hanging. I've made a change to the test so that it retries only 3 times and not until it passes.