{{ message }}
Prevent excessive output on syntax error#93876
Merged
Merged
Conversation
Contributor
clickhouse-gh
Bot
added
the
pr-improvement
robot-ch-test-poll1
added
the
pr-synced-to-cloud
Contributor
|
Hi @alexey-milovidov — while reviewing this PR I found the following:
Happy to discuss — close anything that's wrong or already addressed. |
Contributor
|
Apologies for the duplicate notification — we had a race condition in our notification system where multiple processes posted simultaneously. The duplicate has been removed and we've added a strict 3-layer dedup guard (DB lock + immediate key + GitHub comment check) to ensure this cannot happen again. |
clickgapai
pushed a commit
to clickgapai/ClickHouse
that referenced
this pull request
Apr 3, 2026
…ultiquery scripts The original fix in PR ClickHouse#93876 only addressed generic parse errors and excessive input errors, but missed three other error paths that still used all_queries_end: the lookahead lexical error, post-parse lexical error, and unmatched parentheses. This moves the query boundary computation before those checks and uses it consistently. Closes ClickHouse#101509 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Prevent excessive output on a syntax error. Before this change, it output the whole SQL script, which could contain a lot of queries.
Version info
26.1.1.422