iframe-proxy

ilejn · 2026-01-09T15:42:47Z

Changelog category (leave one):

New Feature

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Implement ADD ENUM VALUES in ALTER TABLE queries to simplify appending new values to an existing Enum type without the need to specify all current Enum values again.

Documentation entry for user-facing changes

Documentation is written (mandatory for new features)

Note

Medium Risk
Adds a new ALTER TABLE syntax and plumbing to merge enum definitions, touching SQL parsing and schema-alter preparation logic; mistakes could break ALTER parsing or allow invalid enum remaps.

Overview
Adds ALTER TABLE ... MODIFY/ALTER COLUMN ... ADD ENUM VALUES (...) to append new members to existing Enum/Enum8/Enum16 columns without restating the full definition, including Nullable(Enum*).

Implements parsing/formatting support (ADD_ENUM_VALUES keyword, ASTAlterCommand::add_enum_values), adds enum-type merge/validation logic (mergeEnumTypes) with conflict and range checks (including optional relative numbering), and wires it into AlterCommands::prepare to produce the updated column type for the mutation.

Updates user docs for Enum and ALTER COLUMN, and adds stateless tests covering success cases and expected errors (non-enum columns, overflow, conflicting name/value, and syntax misuse).

^{Written by Cursor Bugbot for commit 9bf39da. This will update automatically on new commits. Configure here.}

Version info

Merged into: 26.6.1.769

qoega · 2026-01-09T17:04:57Z

+(
+	x Enum('One' = 1, 'Two', 'Three')
+) ENGINE = Memory;
+ALTER TABLE enum MODIFY COLUMN x addToEnum('Zero' = 0, 'Four' = 4);


I think about syntax. We never had function in expression of MODIFY COLUMN
https://clickhouse.com/docs/sql-reference/statements/alter/column#modify-column.

Have you seen any examples of similar logic in other DBMS?

Have you seen any examples of similar logic in other DBMS?

From functional standpoint, not really, PostgreSQL has "ALTER TYPE enum_type_name ADD VALUE 'new_value'" which is probably the best match.

From syntax standpoint, I thought about

ALTER TABLE foo MODIFY COLUMN enumX ADD ENUM VALUES ('VAL_101' = 101, 'VAL_102')

but probably addToEnum is slightly more natural.

From implementation standpoint, addToEnum is a type, and it can be used in too many contexts, which is a drawback I am currently trying to address.

I appreciate any suggestion or thoughts.

I actually think that this example is invalid. It is either pairs or just values. So this will not work

ADD ENUM VALUES ('VAL_101' = 101, 'VAL_102')

This should be fine

ADD ENUM VALUES ('VAL_101', 'VAL_102')

ADD ENUM VALUES ('VAL_101' = 101, 'VAL_102' = 102)

IMHO it is closer to what Postgres and derivatives have. And makes more sense than addToEnum function.

Hello @qoega, thanks for the response.

The example is not really a mistake, currently ClickHouse supports Enum('VAL_101' = 101, 'VAL_102').
That's why it is supported by addToEnum as well.

:) CREATE TABLE default.enum(`x` Enum16('Zero' = 0, 'One' = 1, 'Two' = 2, 'Three' = 3, 'Four' = 4, 'Hundred' = 100, 'Thousand' = 1000, 'ThousandOne' = 1001)) ENGINE = Memory; :) alter table enum modify column x addToEnum('ThousandTen' = 1010, 'ThousandEleven'); :) alter table enum modify column x addToEnum('NextValue'); :) alter table enum modify column x addToEnum('SpecificValue'=42); :) show create table enum format Raw; SHOW CREATE TABLE enum FORMAT Raw Query id: 15b475a4-159e-4067-b7ba-c959c90819fc CREATE TABLE default.enum ( `x` Enum16('Zero' = 0, 'One' = 1, 'Two' = 2, 'Three' = 3, 'Four' = 4, 'SpecificValue' = 42, 'Hundred' = 100, 'Thousand' = 1000, 'ThousandOne' = 1001, 'ThousandTen' = 1010, 'ThousandEleven' = 1011, 'NextValue' = 1012) ) ENGINE = Memory

Of course, addToEnum ('VAL_101', 'VAL_102') and ('VAL_101' = 101, 'VAL_102' = 102) are supported as well.

Anyway, if you believe that
ALTER TABLE foo MODIFY COLUMN enumX ADD ENUM VALUES ('VAL_101' = 101, 'VAL_102')
is better than
ALTER TABLE foo MODIFY COLUMN enumX AddToEnum('VAL_101' = 101, 'VAL_102')

I'll willingly switch to this new syntax, thanks.

I thought that we do not allow mixed ones, but checked that it works, ok.
https://fiddle.clickhouse.com/e9dd95bb-c305-4a5e-9992-b7ee50ad11e1

Yes, this feature is introduced by #36352
But there is some room for improvement #93691

ilejn · 2026-01-21T08:02:09Z

Hello @qoega ,
the reason for this development is the fact some ClickHouse users prefer Enums over LowCardinality (less controllable) or Dictionary (extra fuss, I think). And it is common to add one or two values to a long list.
So the feature seems to be useful and it is requested.

I am not 100% sure about particular syntax, though eventually I get used to it, probably it is not too bad.

What do you think?

mkmkme

Overall looks good. I've added a couple of comments in places that caught my eye.

ilejn · 2026-02-03T09:50:12Z

Hello @qoega , could you please enable tests and review ?

clickhouse-gh · 2026-02-03T10:01:54Z

Workflow [PR], commit [07520f5]

Summary: ✅

Performance Comparison: Performance dashboard

AI Review

Summary

This PR adds ALTER TABLE ... MODIFY COLUMN ... ADD ENUM VALUES for Enum, Enum8, Enum16, and nullable enum columns, with parser/AST support, enum merge validation, metadata-only alter handling, documentation, and focused stateless coverage. I did not find any remaining blocker or major issue in the current diff.

Final Verdict

Status: ✅ Approve

ilejn · 2026-02-09T10:25:23Z

cpp stylecheck believes that

ostr << " ADD ENUM VALUES ( ";

is invalid.

Related code is

    xargs grep $@ -n -P '((class|struct|namespace|enum|if|for|while|else|throw|switch).*|\)(\s*const)?(\s*override)?\s*)\{$|\s$|^ {1,3}[^\* ]\S|\t|^\s*(if|else if|if constexpr|else if constexpr|for|while|catch|switch)\(|\( [^\s\\]|\S \)' |
# a curly brace not in a new line, but not for the case of C++11 init or agg. initialization | trailing whitespace | number of ws not a multiple of 4, but not in the case of comment continuation | missing whitespace after for/if/while... before opening brace | whitespaces inside braces
    grep -v -P '//|\s+\*|\$\(\(| \)"' && echo "^ style error on this line"

I hesitated to improve it, we need an extra layer here to exclude quoted string from check.

ilejn · 2026-05-20T13:03:56Z

Fast test failure is definitely not related.
After

$CLICKHOUSE_CLIENT -q "
    system test view a set fake time '2050-01-01 00:00:01';
    system wait view a;
    system refresh view a;
    system wait view a;
    select '<4.1: fake clock>', status, last_success_time, next_refresh_time, progress, read_rows, total_rows, written_rows, retry from refreshes;

next_refresh_time still belong to 2026 (current time).

Reason: result differs with reference: 
--- /home/ubuntu/actions-runner/_work/ClickHouse/ClickHouse/tests/queries/0_stateless/02932_refreshable_materialized_views_1.reference    2026-05-20 13:42:05.398439153 +0200
+++ /home/ubuntu/actions-runner/_work/ClickHouse/ClickHouse/tests/queries/0_stateless/02932_refreshable_materialized_views_1.213364.stdout    2026-05-20 13:53:19.095476701 +0200
@@ -1,15 +1,15 @@
 <1: created view>        a
 CREATE MATERIALIZED VIEW default.a\nREFRESH EVERY 2 SECOND\n(\n    `x` UInt64\n)\nENGINE = Memory\nDEFINER = default SQL SECURITY DEFINER\nAS SELECT number AS x\nFROM numbers(2)\nUNION ALL\nSELECT rand64() AS x
 <2: refreshed>    3    1    1
 <3: time difference at least>    1000
-<4.1: fake clock>    Scheduled    2050-01-01 00:00:01    2050-01-01 00:00:02    1    3    3    3    0 
+<4.1: fake clock>    Scheduled    2050-01-01 00:00:01    2026-05-20 11:53:16    1    3    3    3    0

Test report https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=93830&sha=8fb42adc14b05bf0a419db37b04a17b6c15a2cf3&name_0=PR&name_1=Fast%20test

# Conflicts: # src/Parsers/ASTAlterQuery.cpp

The branch carried stale auto-generated `.github/workflows` YAML referencing the old `style-checker-aarch64` runner labels; reset them to master's current version so the PR diff stays scoped to the `ADD ENUM VALUES` feature. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

The test was numbered `03774` which now collides with several tests added on master (e.g. `03774_join_pushdown_sharding_bug`, `03774_parquet_empty_tuple`). Renumber to `04307`, past the current highest test number on master. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

alexey-milovidov · 2026-06-03T05:58:32Z

Updated the branch (maintainer push, maintainerCanModify):

Merged master (branch was 941 commits behind; CI was red only on unrelated flakes — see below). Zero conflicts in the feature files (DataTypeEnum, EnumValues, ASTAlterQuery, ParserAlterQuery, AlterCommands).
Reset the auto-generated .github/workflows/*.yml to master's version. The branch carried stale generated YAML still referencing the old style-checker-aarch64 / pr-style-checker-aarch64 runner labels, which is unrelated to this feature and could misroute CI.
Renumbered the test 03774_add_to_enum → 04307_add_to_enum. The 03774 prefix now collides with several tests added on master (e.g. 03774_join_pushdown_sharding_bug, 03774_parquet_empty_tuple); 04307 is past the current highest number.

I rebuilt from the merged tree and verified 04307_add_to_enum locally: all serverError/clientError directives match and the SELECT output is byte-identical to the committed reference (relative numbering, Nullable(Enum*), overflow/conflict errors, SHOW CREATE, syntax-error cases all pass).

The CI failures on the previous run are unrelated to this change:

test_mysql_protocol/test.py::test_mysql_dotnet_client — .NET MySQL client SSL handshake flake (Received unknown response X for SSLRequest), independent of ALTER ... ADD ENUM VALUES.
check_report_messages.py — play.clickhouse.com CIDB connection refused (infra).

The open forEachPointerToChild thread is addressed for this PR (add_enum_values is wired in); the remaining refresh / MODIFY REFRESH observation is a pre-existing issue and out of scope here, as noted.

clickhouse-gh · 2026-06-03T08:44:46Z

📊 Cloud Performance Report

🟢 AI verdict: improvement — 3 query(s) improved out of 38 analysed

This PR adds the ALTER TABLE ... MODIFY COLUMN ... ADD ENUM VALUES syntactic sugar, touching only the SQL parser, Enum type creation/merging, and ALTER command handling. None of that runs in the ClickBench or TPC-H SELECT execution path, and the flagged queries move in both directions, which points to run-to-run variance rather than a real effect, so those flags were downgraded. Three large improvements remain flagged purely by their magnitude (clickbench Q23 -31.8%, tpch Q7 -34.5%, tpch Q20 -47.2%); given the diff these most likely reflect environment differences, and Q20 in particular sits on very noisy measurements. No actionable regression is attributable to this change.

clickbench

🟢 1 improved · ⚠️ 10 inconclusive

Flagged queries (11 of 43)

	Query	Verdict	Baseline med (ms)	PR med (ms)	Change	q-value	Hint
🟢	23	improvement	297	202	-31.8%	<0.0001	Large, consistent -31.8% held by magnitude. PR only changes Enum DDL, so attribution is unclear.
⚠️	4	not_sure	264	227	-14.0%	<0.0001	PR adds Enum ADD-VALUES DDL (parser/DataTypeEnum/AlterCommands); SELECT path untouched. -14% is variance.
⚠️	15	not_sure	246	213	-13.4%	<0.0001	Enum DDL-only change cannot move this SELECT; -13% is variance despite trending history.
⚠️	16	not_sure	796	887	+11.4%	<0.0001	Off-path: PR touches only Enum ALTER/type creation. +11% does not match the diff.
⚠️	17	not_sure	564	621	+10.0%	<0.0001	Enum DDL-only PR; SELECT execution unchanged. +10% regression is run-to-run variance.
⚠️	18	not_sure	1403	1548	+10.3%	<0.0001	Off-path: nothing in the Enum DDL diff runs in this query. +10% is variance.
⚠️	22	not_sure	334	251	-24.9%	<0.0001	-24.85% is below the hard-trust threshold; base measurements very noisy and PR is Enum DDL only.
⚠️	31	not_sure	310	342	+10.3%	<0.0001	Off-path: PR touches only Enum ALTER/type creation. +10% is run-to-run variance.
⚠️	32	not_sure	1367	1505	+10.1%	0.0002	Already not_sure; the two tests disagree. PR is Enum DDL only, off the query path.
⚠️	33	not_sure	1488	1593	+7.1%	0.0003	Off-path Enum DDL change; +7% borderline regression is variance, not a PR effect.
⚠️	34	not_sure	1486	1595	+7.3%	<0.0001	Off-path Enum DDL change; +7% borderline regression is variance, not a PR effect.

_{q-value = BH-FDR adjusted p; smaller is stronger evidence. MIRAI flags a query when q < fdr_q (default 0.10) — the value the verdict is based on.}

tpch_adapted_1_official

🟢 2 improved · ⚠️ 1 inconclusive

Flagged queries (3 of 22)

	Query	Verdict	Baseline med (ms)	PR med (ms)	Change	q-value	Hint
🟢	7	improvement	113	74	-34.5%	<0.0001	Large, consistent -34.5% held by magnitude. PR only changes Enum DDL, so attribution is unclear.
🟢	20	improvement	248	131	-47.2%	<0.0001	-47% held only by magnitude; underlying runs very noisy. PR is Enum DDL, off the query path.
⚠️	8	not_sure	156	182	+17.4%	<0.0001	Enum DDL-only PR; TPC-H has no Enum columns. +17% regression is run-to-run variance.

_{q-value = BH-FDR adjusted p; smaller is stronger evidence. MIRAI flags a query when q < fdr_q (default 0.10) — the value the verdict is based on.}

Debug info

StressHouse run: 4ac35320-3ee4-475d-8d62-5a7a2e22ecbc
MIRAI run: 387ea28a-3dd0-4c03-a748-94408c483401
PR check IDs:
- clickbench_48872_1781381803
- clickbench_48878_1781381803
- clickbench_48884_1781381803
- tpch_adapted_1_official_48887_1781381803
- tpch_adapted_1_official_48894_1781381803
- tpch_adapted_1_official_48905_1781381803

# Conflicts: # src/Storages/AlterCommands.cpp

`AlterCommands::prepare` derived the result of `ADD ENUM VALUES` by merging against the `columns` snapshot, but never advanced that snapshot between commands. As a result `MODIFY COLUMN x ADD ENUM VALUES('a'), MODIFY COLUMN x ADD ENUM VALUES('b')` produced `base + b` and silently dropped `a`, because both commands merged against the original type and were then applied sequentially. Write the merged type back into the working snapshot so subsequent commands in the same statement see the already-extended type. Additionally, `ADD ENUM VALUES` computes its type only when the column is present in the snapshot. When the column is added by a preceding `ADD COLUMN` in the same statement (which does not advance the snapshot), the modification was silently dropped. Fail explicitly with `NO_SUCH_COLUMN_IN_TABLE` instead. Addresses review feedback on `src/Storages/AlterCommands.cpp`. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

alexey-milovidov · 2026-06-07T15:35:00Z

Merged master (the branch was ~1002 commits behind and red), resolving a conflict in src/Storages/AlterCommands.cpp (both sides added a helper to the same anonymous namespace — kept both).

Addressed review feedback

Fixed the unresolved bot thread on AlterCommands.cpp about chained ADD ENUM VALUES in a single statement (6b03661059a):

prepare now advances its working columns snapshot after each ADD ENUM VALUES, so MODIFY COLUMN x ADD ENUM VALUES('a'), MODIFY COLUMN x ADD ENUM VALUES('b') keeps both a and b (previously dropped a).
When the target column is absent from the snapshot (e.g. added by a preceding ADD COLUMN in the same statement), it now fails with NO_SUCH_COLUMN_IN_TABLE instead of silently dropping the modification (fail-close).
Added regression tests for both cases in 04307_add_to_enum; verified the full test passes against a local build.

CI analysis (all three failures unrelated to this PR)

00175_obfuscator_schema_inference (amd_tsan) — widely flaky: 126 FAIL/ERROR across many PRs incl. master (pull_request_number = 0) in the last 30 days; the test harness itself diagnosed it as flaky (5/9 reruns failed).
03366_bfloat16_sorting (amd_debug) — ORDER BY x over BFloat16 values where many distinct literals (including +0.0/-0.0/0.0) round to the same value; equal keys sort nondeterministically (the diff was exactly -0 vs 0 reordering). Also failed on unrelated PR Fix sparse serialization replacing -0.0 with +0.0 #100983.
Unit tests (asan_ubsan) — UBSan null-pointer in UntrackedMemoryRegistry::remove (boost::intrusive list). This is master-wide (failures on pull_request_number = 0, Fix for #101423 GRANT SELECT(column) does not give access to its subcolumns #103402, Use primary key and skip indexes for boolean-position ifNull/coalesce predicates #106272 on 2026-06-03) and was caused by code already reverted in 3930f8abb8a ("Revert Add UntrackedMemory asynchronous metric"). That revert is in the master now merged here, and the offending file no longer exists, so this cannot recur on the updated branch.

@groeneai, the two flaky tests 00175_obfuscator_schema_inference and 03366_bfloat16_sorting are unrelated to this PR; please investigate and provide fixes in separate PRs if they are not already tracked. The UntrackedMemoryRegistry UBSan failure is already resolved by the revert 3930f8abb8a on master.

groeneai · 2026-06-07T16:28:13Z

@alexey-milovidov, status on the two flaky tests:

00175_obfuscator_schema_inference (amd_tsan): already tracked and resolved. Same root cause as the sibling 00096_obfuscator_save_load: the UntrackedMemory asynchronous metric (Add UntrackedMemory asynchronous metric #104690) was reverted by Revert "Add UntrackedMemory asynchronous metric" #106365 on 2026-06-03. CIDB master post-revert shows 0 hits over 58+ runs (the only 2026-06-03 hit was on commit 05a3c69, which is a pre-revert ancestor whose CI started after the revert merged). I'm monitoring the reapply attempt Reapply "Add UntrackedMemory asynchronous metric" #106386.
03366_bfloat16_sorting (amd_debug): not previously tracked, fix PR opened — Fix flaky test 03366_bfloat16_sorting #106684. It pins max_threads = 1 in the query's SETTINGS clause so MergeSortingTransform produces a deterministic relative order for the five BFloat16 zero-equivalents (+0.0, +0.0, 0.0, -0.0, 0.0) that all round to the same key. CI history: 4 hits across 4 unrelated PRs in 90 days, 0 master.

The UntrackedMemoryRegistry UBSan failure is already resolved by 3930f8abb8a as you noted.

@alexey-milovidov

The test sorts a hand-built `BFloat16` array that contains five values which all round to the same `BFloat16` representation (`+0.0`, `+0.0`, `0.0`, `-0.0`, `0.0`). Equal sort keys have an implementation-defined relative order; under enough query-plan randomization the relative order of `-0` against the surrounding `0`s changes, and the result no longer matches the byte-exact `.reference` file. Pinning `max_threads = 1` makes the order produced by `MergeSortingTransform` deterministic and matches the committed reference. The test still exercises sorting of `BFloat16` values across the full input. Diagnosed by @alexey-milovidov on ClickHouse#93830 (comment) CI history: 4 hits across 4 unrelated PRs in 90 days (ClickHouse#93830, ClickHouse#100983, ClickHouse#100649, ClickHouse#96130), 0 master failures, 78957 OK runs / 1 FAIL in 30 days.

# Conflicts: # src/DataTypes/EnumValues.cpp # src/DataTypes/EnumValues.h

alexey-milovidov · 2026-06-09T04:30:02Z

Merged latest `master` to resolve conflicts. Since the last merge, `master` replaced the hash-map-based `EnumValues` with the new compact storage (Replace EnumValues hash maps with compact storage + follow-ups), which conflicted with this PR's `ValidationMode` plumbing through the old `fillMaps`.

Re-threaded `ValidationMode` through the new `buildLookupStructures`:

`ValidationMode::Normal` is unchanged (sort by value, full dup-name + dup-value validation, build value-to-name lookup).
`ValidationMode::TemporaryAdd` keeps parser order (per-element relative flags are positional) and skips dup-value validation, as before. Additionally it now skips building the value-to-name lookup structures: a `TemporaryAdd` instance is unsorted and may hold duplicate placeholder values, so the compact direct-lookup build would compute a negative range and overflow `value_to_index.resize`. This is safe because a `TemporaryAdd` instance is only ever read via `getValues()` / `generateName` / `getRelativeFlagsSize` (in `mergeEnumTypes` and the ctor) and is never queried by value. The dup-name check is preserved.

Built locally and `04307_add_to_enum` passes against a fresh server.

ilejn · 2026-06-10T12:54:37Z

I prohibited a combination of MODIFY ... MODIFY ADD ENUM VALUES without column restrictions.

Advancing snapshot after any MODIFY COLUMN seems too risky.
I tried to handle snapshot before ADD ENUM VALUES (not after), but the change looks too invasive.

Update: now it is possible to have MODIFY and MODIFY ADD ENUM VALUES for different columns.

ilejn · 2026-06-11T08:08:28Z

Hello @alexey-milovidov , I [obviously] cannot sync with private repo.

# Conflicts: # src/DataTypes/DataTypeEnum.cpp

clickhouse-gh · 2026-06-13T18:09:31Z

LLVM Coverage Report

Changed lines: Changed C/C++ lines covered by tests: 291/303 (96.04%) | Lost baseline coverage: none · Uncovered code

Full report · Diff report

ilejn added 5 commits January 8, 2026 10:04

add_enum: initial, slightly works

67fbf59

add_enum: 8/16 mix

5d2d86c

add_enum: test and small improvements

ddab03e

add_enum: doc, code cleanup, new tests

214eb58

add_enum: prohibit ALTER ... addToEnum against non-enum

3e07164

qoega reviewed Jan 9, 2026

View reviewed changes

ilejn added 2 commits January 9, 2026 19:14

add_enum: don't register addToEnum as type

33f2021

add_enum: Nullable, auto assign numbers

6e1dfd2

ilejn marked this pull request as ready for review January 11, 2026 23:24

Merge remote-tracking branch 'origin/master' into add_enum

04d1105

ilejn added 5 commits January 28, 2026 10:20

add_enum: ADD ENUM VALUES slightly works with ASTFunction

d9ac982

add_enum: switched to ASTExpressionList

d2040eb

add_enum: cleanup, test & doc updated according to changes

6d6184a

Merge remote-tracking branch 'origin/master' into add_enum

d6beede

add_enum: reflect changes in master

9617651

ilejn changed the title ~~addToEnum~~ ADD ENUM VALUES Jan 30, 2026

mkmkme mentioned this pull request Feb 2, 2026

Error message 'All elements of Enum data type must be of form ...' is not quite accurate #93691

Open

mkmkme reviewed Feb 2, 2026

View reviewed changes

Comment thread docs/en/sql-reference/data-types/enum.md Outdated

Comment thread src/Interpreters/InterpreterAlterQuery.cpp Outdated

Comment thread src/Storages/AlterCommands.cpp Outdated

Comment thread tests/queries/0_stateless/04307_add_to_enum.sql.j2

add_enum: per review. No ASTAlterCommand::ADD_ENUM_VALUES, new tests

96d01d1

clickhouse-gh Bot added the pr-feature Pull request with new product feature label Feb 3, 2026

qoega added the can be tested Allows running workflows for external contributors label Feb 6, 2026

add_enum: make style check happy

9130fc1

ilejn added 4 commits February 9, 2026 10:39

add_enum: typo fixed

02774c9

add_enum: get rid of tabs in doc

77377c2

Merge remote-tracking branch 'origin/master' into add_enum

d159b05

add_enum: exclude inserting unknown enum element from the test

54c05f9

Merge remote-tracking branch 'origin/master' into add_enum

8fb42ad

ilejn mentioned this pull request May 20, 2026

last_success_time / next_refresh_time inconsistency in system.view_refreshes #105479

Open

ilejn and others added 2 commits May 22, 2026 08:25

Merge remote-tracking branch 'origin/master' into add_enum

5294b63

Merge remote-tracking branch 'origin/master' into add_enum

d312ca9

# Conflicts: # src/Parsers/ASTAlterQuery.cpp

clickhouse-gh Bot added the manual approve Manual approve required to run CI label May 29, 2026

alexey-milovidov and others added 3 commits June 3, 2026 05:46

Merge remote-tracking branch 'origin/master' into add_enum

b20486e

clickhouse-gh Bot reviewed Jun 3, 2026

View reviewed changes

Comment thread src/Storages/AlterCommands.cpp

alexey-milovidov and others added 2 commits June 7, 2026 15:21

Merge remote-tracking branch 'origin/master' into add_enum

7244f93

# Conflicts: # src/Storages/AlterCommands.cpp

groeneai mentioned this pull request Jun 7, 2026

Fix flaky test 03366_bfloat16_sorting #106684

Merged

1 task

Merge remote-tracking branch 'origin/master' into add_enum

2a9c4f2

# Conflicts: # src/DataTypes/EnumValues.cpp # src/DataTypes/EnumValues.h

clickhouse-gh Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread src/Storages/AlterCommands.cpp

add_enum: prohibit combination of MODIFY ... MODIFY ADD ENUM VALUES

c74fa6d

clickhouse-gh Bot reviewed Jun 10, 2026

View reviewed changes

Comment thread src/Storages/AlterCommands.cpp Outdated

add_enum: mind column prohibiting MODIFY ... MODIFY ADD ENUM VALUES

979be41

Merge remote-tracking branch 'origin/master' into add_enum

07520f5

# Conflicts: # src/DataTypes/DataTypeEnum.cpp

alexey-milovidov merged commit 1a5e24c into ClickHouse:master Jun 13, 2026
165 of 166 checks passed

robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 13, 2026

Sunbelt Computer Software

PL/B Language Development and Support

Uh oh!

Conversation

ilejn commented Jan 9, 2026 • edited by robot-clickhouse Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changelog category (leave one):

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Documentation entry for user-facing changes

Version info

Uh oh!

qoega Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

ilejn Jan 9, 2026

Choose a reason for hiding this comment

Uh oh!

qoega Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

ilejn Jan 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

qoega Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

ilejn Jan 25, 2026

Choose a reason for hiding this comment

Uh oh!

ilejn commented Jan 21, 2026

Uh oh!

mkmkme left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ilejn commented Feb 3, 2026

Uh oh!

clickhouse-gh Bot commented Feb 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

AI Review

Summary

Final Verdict

Uh oh!

ilejn commented Feb 9, 2026

Uh oh!

ilejn commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexey-milovidov commented Jun 3, 2026

Uh oh!

Uh oh!

clickhouse-gh Bot commented Jun 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

clickbench

tpch_adapted_1_official

Uh oh!

alexey-milovidov commented Jun 7, 2026

Addressed review feedback

CI analysis (all three failures unrelated to this PR)

Uh oh!

groeneai commented Jun 7, 2026

Uh oh!

alexey-milovidov commented Jun 9, 2026

Uh oh!

Uh oh!

ilejn commented Jun 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

ilejn commented Jun 11, 2026

Uh oh!

clickhouse-gh Bot commented Jun 13, 2026

LLVM Coverage Report

Uh oh!

Uh oh!

Reviewers

ilejn commented Jan 9, 2026 •

edited by robot-clickhouse

Loading

ilejn Jan 25, 2026 •

edited

Loading

clickhouse-gh Bot commented Feb 3, 2026 •

edited

Loading

ilejn commented May 20, 2026 •

edited

Loading

clickhouse-gh Bot commented Jun 3, 2026 •

edited

Loading

ilejn commented Jun 10, 2026 •

edited

Loading