Add the setting to ignore ON CLUSTER clause for replicated databases by kirillgarbar · Pull Request #92872 · ClickHouse/ClickHouse · GitHub
Skip to content

Add the setting to ignore ON CLUSTER clause for replicated databases#92872

Merged
evillique merged 3 commits into
ClickHouse:masterfrom
kirillgarbar:ignore-cluster-replicated-db
Dec 24, 2025
Merged

Add the setting to ignore ON CLUSTER clause for replicated databases#92872
evillique merged 3 commits into
ClickHouse:masterfrom
kirillgarbar:ignore-cluster-replicated-db

Conversation

@kirillgarbar

Copy link
Copy Markdown
Contributor

Changelog category (leave one):

  • New Feature

Changelog entry (a [user-readable short description]

It is possible to execute DDL queries with ON CLUSTER clause for a Replicated database if the ignore_on_cluster_for_replicated_database setting is enabled. In this case, the cluster name will be ignored.

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Basically reopening #84176. Main use case is for a seamless migration of a database to replicated engine, so users can still use their old ON CLUSTER ddl queries without change.
In some cases ignoring cluster name can be unexpected behaviour, so using a setting for this feature can fix that.

Comment thread src/Interpreters/executeDDLQueryOnCluster.cpp Outdated

@evillique evillique left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new setting should be added in src/Core/SettingsChangesHistory.cpp

@evillique evillique self-assigned this Dec 23, 2025
@evillique evillique added the can be tested Allows running workflows for external contributors label Dec 23, 2025
@clickhouse-gh

clickhouse-gh Bot commented Dec 23, 2025

Copy link
Copy Markdown
Contributor

@clickhouse-gh clickhouse-gh Bot added the pr-feature Pull request with new product feature label Dec 23, 2025
kirillgarbar and others added 2 commits December 23, 2025 14:26
Co-authored-by: Nikolay Degterinsky <43110995+evillique@users.noreply.github.com>
@evillique evillique added this pull request to the merge queue Dec 24, 2025
Merged via the queue into ClickHouse:master with commit 3561526 Dec 24, 2025
127 of 131 checks passed
@robot-ch-test-poll3 robot-ch-test-poll3 added the pr-synced-to-cloud The PR is synced to the cloud repo label Dec 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-feature Pull request with new product feature pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants