Check if encrypted disks support writing with append by tuanpach · Pull Request #89999 · ClickHouse/ClickHouse · GitHub
Skip to content

Check if encrypted disks support writing with append#89999

Merged
tuanpach merged 2 commits into
ClickHouse:masterfrom
tuanpach:fix-84669-2nd-attempt
Nov 17, 2025
Merged

Check if encrypted disks support writing with append#89999
tuanpach merged 2 commits into
ClickHouse:masterfrom
tuanpach:fix-84669-2nd-attempt

Conversation

@tuanpach

@tuanpach tuanpach commented Nov 13, 2025

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • CI Fix or Improvement (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

Check if encrypted disks support writing with append. Resolves #84669

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

Details

Closes #84669

@tuanpach tuanpach added the can be tested Allows running workflows for external contributors label Nov 13, 2025
@clickhouse-gh

clickhouse-gh Bot commented Nov 13, 2025

Copy link
Copy Markdown
Contributor

@clickhouse-gh clickhouse-gh Bot added the pr-ci label Nov 13, 2025
@kssenii kssenii self-assigned this Nov 13, 2025

@kssenii kssenii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check if cache disks and encrypted disks support writing with append

I think this only affected encypted disk, not cached, as cached disk is just DiskObjectStorage<CachedObjectStorage>, e.g. dynamic_cast<DiskObjectStorage *> works for it.

Comment thread src/Disks/supportWritingWithAppend.cpp Outdated
@tuanpach tuanpach force-pushed the fix-84669-2nd-attempt branch from e81365a to 8a9c118 Compare November 14, 2025 00:03
@tuanpach tuanpach changed the title Check if cache disks and encrypted disks support writing with append Check if encrypted disks support writing with append Nov 14, 2025
@tuanpach

Copy link
Copy Markdown
Member Author

@tuanpach tuanpach enabled auto-merge November 15, 2025 00:56
@tuanpach tuanpach disabled auto-merge November 17, 2025 01:25
@tuanpach tuanpach added this pull request to the merge queue Nov 17, 2025
Merged via the queue into ClickHouse:master with commit fc70889 Nov 17, 2025
125 of 130 checks passed
@tuanpach tuanpach deleted the fix-84669-2nd-attempt branch November 17, 2025 08:53
@robot-ch-test-poll robot-ch-test-poll added the pr-synced-to-cloud The PR is synced to the cloud repo label Nov 17, 2025
ianton-ru pushed a commit to Altinity/ClickHouse that referenced this pull request Mar 4, 2026
Check if encrypted disks support writing with append

Signed-off-by: Anton Ivashkin <ianton@live.com>
zvonand added a commit to Altinity/ClickHouse that referenced this pull request Mar 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

can be tested Allows running workflows for external contributors pr-ci pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Stress test fails with Disk does not support WriteMode::Append

3 participants