Fix "While sending batch" error message is too long by zhongyuankai · Pull Request #77609 · ClickHouse/ClickHouse · GitHub
Skip to content

Fix "While sending batch" error message is too long#77609

Merged
azat merged 2 commits into
ClickHouse:masterfrom
zhongyuankai:err_msg_too_long
Mar 17, 2025
Merged

Fix "While sending batch" error message is too long#77609
azat merged 2 commits into
ClickHouse:masterfrom
zhongyuankai:err_msg_too_long

Conversation

@zhongyuankai

@zhongyuankai zhongyuankai commented Mar 14, 2025

Copy link
Copy Markdown
Contributor

Avoid printing logs that are too long.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

...

Documentation entry for user-facing changes

  • Documentation is written (mandatory for new features)

@azat azat self-assigned this Mar 14, 2025
azat
azat reviewed Mar 14, 2025
View reviewed changes

@azat azat left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little history of this change.

  • In #41813 this has been added initially (by you)
  • But, it has a bug, that has been fixed in #44907
  • But in #44922 (that got reapplied in #45491) I've removed this error prone file_index_to_path

So now it is safe

Comment thread src/Storages/Distributed/DistributedAsyncInsertBatch.cpp Outdated
@zhongyuankai

zhongyuankai commented Mar 14, 2025

Copy link
Copy Markdown
Contributor Author

@azat

azat commented Mar 14, 2025

Copy link
Copy Markdown
Member

Do we still need this PR?

I'm OK with it, let's replace boost::adaptors with std::range

@azat azat added the can be tested Allows running workflows for external contributors label Mar 16, 2025
@clickhouse-gh

clickhouse-gh Bot commented Mar 16, 2025

Copy link
Copy Markdown
Contributor

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Mar 16, 2025
@azat azat added this pull request to the merge queue Mar 17, 2025
Merged via the queue into ClickHouse:master with commit 33e873c Mar 17, 2025
@robot-ch-test-poll1 robot-ch-test-poll1 added the pr-synced-to-cloud The PR is synced to the cloud repo label Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@azat azat azat approved these changes

Assignees

@azat azat

Labels

can be tested Allows running workflows for external contributors pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@zhongyuankai @azat @robot-ch-test-poll1