feature drop detached table#62490
Conversation
yariks5s
added
the
can be tested
k-morozov
changed the title
|
This is an automatic comment. The PR descriptions does not match the template. Please, edit it accordingly. The error is: Changelog entry required for category 'New Feature' |
| { | ||
| if (query.kind == ASTDropQuery::Kind::Drop) | ||
| { | ||
| auto database = DatabaseCatalog::instance().getDatabase(table_id.getDatabaseName()); |
There was a problem hiding this comment.
In general it's a strange case, because we have to check the query.if_exists, otherwise the exception (database does not exist) will occurs . But as for me IF EXISTS statement should check that table exists and ready to use, but it is detached (does this mean that the table exists or not?). Assume that we won't have such questions if alter table drop detached is used.
Let's keep it as is, the folks from ch will help.
|
Dear @tavplubix, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself. |
|
The Fast test failure is probably related, I don't think merging master will help |
k-morozov
force-pushed
the
feature/drop_detached_tables
branch
from
1577dad to
fe8699d
Compare
The issue was related to the length of the table's name. |
6 participants
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Feature for drop detached table.
Documentation entry for user-facing changes
Add feature to execute DROP TABLE for detached tables.
Modify your CI run:
NOTE: If your merge the PR with modified CI you MUST KNOW what you are doing
NOTE: Checked options will be applied if set before CI RunConfig/PrepareRunConfig step
Include tests (required builds will be added automatically):
Exclude tests:
Extra options:
Only specified batches in multi-batch jobs: