{{ message }}
Use encrypted disks for tests with S3 by default#59898
Merged
Merged
Conversation
robot-ch-test-poll
added
the
pr-build
Contributor
alexey-milovidov
approved these changes
Feb 12, 2024
kssenii
reviewed
Feb 12, 2024
Contributor
|
Dear @alexey-milovidov, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself. |
Member
|
@nikitamikhaylov this change is approved, let's continue! |
nikitamikhaylov
force-pushed
the
encryption-s3-by-default
branch
from
6809cf9 to
4d11dd5
Compare
nikitamikhaylov
force-pushed
the
encryption-s3-by-default
branch
from
4d11dd5 to
9be5f98
Compare
Contributor
nikitamikhaylov
force-pushed
the
encryption-s3-by-default
branch
from
9be5f98 to
be815bf
Compare
antonio2368
force-pushed
the
encryption-s3-by-default
branch
from
b2b7bd9 to
ac4e668
Compare
Contributor
|
Dear @antonio2368, this PR hasn't been updated for a while. You will be unassigned. Will you continue working on it? If so, please feel free to reassign yourself. |
Member
antonio2368
force-pushed
the
encryption-s3-by-default
branch
2 times, most recently
from
9baa1a4 to
0827f54
Compare
nikitamikhaylov
force-pushed
the
encryption-s3-by-default
branch
2 times, most recently
from
f71cbad to
8ea7c51
Compare
antonio2368
force-pushed
the
encryption-s3-by-default
branch
from
77a8e7f to
15c40b7
Compare
antonio2368
force-pushed
the
encryption-s3-by-default
branch
from
15c40b7 to
b199cb5
Compare
antonio2368
force-pushed
the
encryption-s3-by-default
branch
from
399e769 to
815d210
Compare
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
13 tasks
zvonand
pushed a commit
to Altinity/ClickHouse
that referenced
this pull request
Sep 2, 2025
…default Use encrypted disks for tests with S3 by default
1 task
pull Bot
pushed a commit
to Lobinson1/ClickHouse
that referenced
this pull request
May 25, 2026
After ClickHouse#92141 refactored version metadata to use atomic tmp+rename writes instead of `WriteMode::Append`, the race that previously corrupted `txn_version.txt` on encrypted disks (see ClickHouse#59898 discussion) is no longer possible: concurrent `creation_csn` and `removal_tid` updates can no longer interleave inside the encrypted append path. Install `transactions.xml` in encrypted-storage CI jobs and drop the `no-encrypted-storage` tag from transaction-related stateless tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
Use encrypted disks for tests with S3 by default.