{{ message }}
Add columns in columns.sql for INFORMATION_SCHEMA#29637
Merged
Conversation
tavplubix
approved these changes
Oct 7, 2021
Member
There was a problem hiding this comment.
Ok, but I'm not sure that NULL is better than data_type
Contributor
Author
There was a problem hiding this comment.
But we already have type AS data_type.
Member
There was a problem hiding this comment.
So why do we need column_type column if we already have data_type column? :)
Contributor
Author
…kHouse into add_sql_columns
1 task
pull Bot
pushed a commit
to AKJUS/ClickHouse
that referenced
this pull request
May 18, 2026
The test asserted a deterministic row-by-row output from: SELECT val, avg(toUInt32(val)) FROM t_group_by_lowcardinality GROUP BY val LIMIT 10 SETTINGS max_threads = 1, max_rows_to_group_by = 100, group_by_overflow_mode = 'any'; With `group_by_overflow_mode = 'any'`, only the first `max_rows_to_group_by` distinct keys make it into the hash table — and which keys those are depends on the order in which rows arrive at the aggregator. `LIMIT 10` without `ORDER BY` then selects ten of those keys in hash-iteration order. The `max_threads = 1` clause does not help under `ParallelReplicas` (where the table is sharded across replicas and partial aggregations are merged) or under S3 storage (where reads can be split into independent ranges), so the resulting row set varies between runs. Originally tracked in ClickHouse#36069 (2022). The `-- Tags: no-random-settings` workaround masked the issue for random-settings randomization but the underlying non-determinism returned once `ParallelReplicas` was enabled by default in some CI configurations. Concretely the test now fails ~10–20 times per day on master under `Stateless tests (amd_llvm_coverage, ParallelReplicas, s3 storage, parallel)` — @alexey-milovidov flagged this on ClickHouse#102039. The test is a crash-regression test for "Avoid crash in case of GROUP BY LowCardinality(Nullable(String)) column and group_by_overflow_mode='any'" (PR ClickHouse#29637 / ClickHouse#56057). The query is preserved verbatim, including all the problematic settings; only the assertion is changed to `SELECT count() FROM (...) `, which is always 10. If the underlying crash ever returns, the test will detect it; the specific row values were never deterministic to begin with. Verified locally that the old reference fails under `max_threads = 4` (extra null bucket appears, last row drops — exact diff matches the CI report). The new assertion returns `{"count()":10}` for all parallelism levels. Closes ClickHouse#36069
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):
...
Detailed description / Documentation draft:
add columns to avoid errors.