Support MySQL 'SELECT DATABASE()' by bohutang · Pull Request #12314 · ClickHouse/ClickHouse · GitHub
Skip to content

Support MySQL 'SELECT DATABASE()'#12314

Merged
alexey-milovidov merged 2 commits into
ClickHouse:masterfrom
bohutang:mysql_select_database
Jul 10, 2020
Merged

Support MySQL 'SELECT DATABASE()'#12314
alexey-milovidov merged 2 commits into
ClickHouse:masterfrom
bohutang:mysql_select_database

Conversation

@bohutang

@bohutang bohutang commented Jul 9, 2020

Copy link
Copy Markdown
Contributor

I hereby agree to the terms of the CLA available at: https://yandex.ru/legal/cla/?lang=en

Changelog category (leave one):

  • Improvement

Changelog entry (a user-readable short description of the changes that goes to CHANGELOG.md):

  1. Support MySQL 'SELECT DATABASE()' Enhanced MySQL compatibility #9336
  2. Add MySQL replacement query integration test

Detailed description / Documentation draft:

...

By adding documentation, you'll allow users to try your new feature immediately, not when someone else will have time to document it later. Documentation is necessary for all features that affect user experience in any way. You can add brief documentation draft above, or add documentation right into your patch as Markdown files in docs folder.

If you are doing this for the first time, it's recommended to read the lightweight Contributing to ClickHouse Documentation guide first.

@robot-clickhouse robot-clickhouse added the pr-improvement Pull request with some product improvements label Jul 9, 2020

@alexey-milovidov alexey-milovidov left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's Ok to have database as a case-insensitive synonim to currentDatabase function.

@bohutang

bohutang commented Jul 9, 2020

Copy link
Copy Markdown
Contributor Author

@bohutang bohutang force-pushed the mysql_select_database branch from 79edfa1 to 260bcb9 Compare July 9, 2020 14:27
@bohutang bohutang marked this pull request as ready for review July 9, 2020 14:29
@bohutang bohutang requested a review from alexey-milovidov July 9, 2020 17:59
@alexey-milovidov alexey-milovidov merged commit 8d7e418 into ClickHouse:master Jul 10, 2020
@alexey-milovidov

Copy link
Copy Markdown
Member

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-improvement Pull request with some product improvements

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants