{{ message }}
Cherry pick #108488 to 25.8: Do not cache query condition results for sampled reads#109146
Closed
robot-ch-test-poll3 wants to merge 3 commits into
Closed
Cherry pick #108488 to 25.8: Do not cache query condition results for sampled reads#109146robot-ch-test-poll3 wants to merge 3 commits into
robot-ch-test-poll3 wants to merge 3 commits into
Conversation
The query condition cache key encodes only the WHERE/PREWHERE predicate, not the SAMPLE clause. A `SELECT ... SAMPLE x WHERE cond` query reads only the marks the sampling key selects, then records that sampling-narrowed mark mask under the predicate hash. A later non-sampled query with the same predicate reuses the under-counted mask, skips the marks SAMPLE excluded, and silently returns too few rows. Disable the query condition cache (both the index-analysis write and the runtime PREWHERE/WHERE write) whenever the read uses sampling, mirroring the existing FINAL / bucket_id guards in the disable-cascade. The consult side is left unchanged: once writes are blocked during sampling the cache only ever holds full-predicate masks, and a predicate-false mark stays predicate-false under any sample subset, so sampled reads still benefit from previously cached full-scan verdicts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Do not cache query condition results for sampled reads
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Original pull-request #108488
Do not merge this PR manually
This pull-request is a first step of an automated backporting.
It contains changes similar to calling
git cherry-picklocally.If you intend to continue backporting the changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.
The check results does not matter at this step - you can safely ignore them.
Troubleshooting
If the conflicts were resolved in a wrong way
If this cherry-pick PR is completely screwed by a wrong conflicts resolution, and you want to recreate it:
pr-cherrypicklabel from the PRYou also need to check the Original pull-request for
pr-backports-createdlabel, and delete if it's presented thereThe PR source
The PR is created in the CI job