{{ message }}
Prune stale Darwin fast-test skips; fix isLocalAddress for lo0 aliases#108630
Merged
Algunenano merged 23 commits intoJun 29, 2026
Conversation
…batch8 # Conflicts: # ci/defs/darwin.skip
Contributor
…fixes macOS RemoteSource spin)
…nc query-sending startup
Contributor
LLVM Coverage ReportChanged lines: Changed C/C++ lines covered by tests: 30/33 (90.91%) | Lost baseline coverage: none · Uncovered code |
Merged
via the queue into
ClickHouse:master
with commit Jun 29, 2026
45cf5f6
342 of 344 checks passed
robot-ch-test-poll3
added
the
pr-synced-to-cloud
This was referenced Jun 30, 2026
1 task
This was referenced Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prunes stale entries from the macOS/Darwin fast-test skip list (
ci/defs/darwin.skip) by verifying which skipped tests now pass on Apple arm64 and un-skipping them. Each un-skipped test was run 20x consecutively before removal.The main enabler is a fix to
isLocalAddress:127.0.0.{2..255}are now decided as non-local by value alone, never falling through to the interface scan. On macOS those addresses get assigned tolo0as aliases to emulate distributed queries, which previously made them "local" and collapsed remote shards into local serial execution. This matches Linux behaviour and unblocks ~140 distributed/remote()tests.Other changes:
#comments indarwin.skipand group remaining entries into commented sections by known reason.01317_no_password_in_command_lineasno-darwin(relies on BSDps/procfs).Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Version info
26.7.1.252