{{ message }}
Mark getClientHTTPHeader as non-deterministic#108029
Merged
Merged
Conversation
getClientHTTPHeader reads per-request HTTP headers but inherited the default isDeterministic() == true, so the query result cache could reuse a stale value for a later request. Other runtime-dependent functions (queryID, currentDatabase, connectionId, initialQueryID) already override isDeterministic to return false. Closes: #101120 Related: #102766 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
clickhouse-gh
Bot
added
the
pr-bugfix
Contributor
LLVM Coverage Report
Changed lines: Changed C/C++ lines covered by tests: 3/4 (75.00%) | Lost baseline coverage: none · Uncovered code |
Algunenano
approved these changes
Jun 24, 2026
robot-ch-test-poll
added
the
pr-synced-to-cloud
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getClientHTTPHeaderreturns a per-request value (it reads the HTTP headers of the current request), so it is non-deterministic. It did not overrideisDeterministic, so it inherited the defaulttrue. As a consequence the query result cache treated queries using it as cacheable, which could return a stale header value for a later request. Other runtime-dependent functions (queryID,currentDatabase,connectionId,initialQueryID) already overrideisDeterministicto returnfalse.This revives the change from the closed PR #102766 (closed for process reasons), adds a regression test, and rebases it onto current
master.Closes: #101120
Related: #102766
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
getClientHTTPHeaderis now correctly treated as non-deterministic, so its result is no longer incorrectly reused by the query result cache.Documentation entry for user-facing changes
Version info
26.6.1.1198