{{ message }}
Add sccache-warmup release builds to MasterCI#107766
Merged
Merged
Conversation
Contributor
![clickhouse-gh[bot]](https://avatars.githubusercontent.com/in/928874?s=60&v=4){kind=small}
maxknv
force-pushed
the
ci-master-sccache-warmup-release
branch
from
3c3988f to
ecca469
Compare
Member
Author
|
BuzzHouse errors fixed in #107900 |
The `MasterCI` `Build (amd_release)` / `Build (arm_release)` jobs compile with different cmake flags than the same jobs in the `PR` workflow: on master (`pr_number == 0`) they add `-DCLICKHOUSE_OFFICIAL_BUILD=1` and keep debug symbols, while PR builds add `-DDISABLE_ALL_DEBUG_SYMBOLS=1` and no official-build flag. Different flags produce different sccache keys, so the shared sccache populated by master cannot be reused by PR release builds. Add two MasterCI-only build types, `amd_release_pr_cache_warmup` and `arm_release_pr_cache_warmup`, that compile with the PR release build's cmake flags (no official-build flag, debug symbols stripped, no PGO/BOLT) while keeping the shared sccache read-write (master writes, PR reads read-only). This populates the cache so read-only PR release builds get cache hits. The warmup builds only need to populate the compiler cache, so they compile every translation unit but skip linking the final binaries (the ThinLTO link step produces nothing cacheable yet dominates wall time), provide no artifacts, and run no profile/master-head post hooks. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
maxknv
force-pushed
the
ci-master-sccache-warmup-release
branch
from
ecca469 to
8dc3892
Compare
Contributor
|
📊 Cloud Performance Report ✅ AI verdict: This PR only adds sccache-warmup build jobs to the master CI pipeline (CI workflow definitions and build scripts); it changes nothing in the query-execution code path. The flagged ClickBench improvements on Q4 (-16%), Q15 (-17%), Q28 (-7%), and Q34 (-6%) therefore cannot be caused by this change and have been downgraded to not-sure as run-to-run variance. Q32 was already inconclusive and remains so. No action needed on performance grounds. clickbenchFlagged queries (5 of 43)q-value = BH-FDR adjusted p; smaller is stronger evidence. MIRAI flags a query when q < fdr_q (default 0.10) — the value the verdict is based on. tpch_adapted_1_official🟢 No significant changes Debug info
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The MasterCI
Build (amd_release)/Build (arm_release)jobs compile withdifferent cmake flags than the same jobs in the PR workflow: on master
(
pr_number == 0) they add-DCLICKHOUSE_OFFICIAL_BUILD=1and keep debugsymbols, while PR builds add
-DDISABLE_ALL_DEBUG_SYMBOLS=1and noofficial-build flag. Different flags produce different sccache keys, so the
shared sccache populated by master cannot be reused by PR release builds.
This adds two MasterCI-only build types,
amd_release_pr_cache_warmupandarm_release_pr_cache_warmup, that compile with the PR release build's cmakeflags (no official-build flag, debug symbols stripped, no PGO/BOLT) while
keeping the shared sccache read-write (master writes, read-only PR builds
read). This warms the cache so read-only PR release builds get cache hits.
The warmup builds only populate the compiler cache, so they compile every
translation unit but skip linking the final binaries (the ThinLTO link step
produces nothing cacheable yet dominates wall time), provide no artifacts,
and run no profile/master-head post hooks.
Changelog category (leave one):
Version info
26.6.1.1189