Deprecate the cloud_mode_database_engine setting by evillique · Pull Request #107372 · ClickHouse/ClickHouse · GitHub
Skip to content

Deprecate the cloud_mode_database_engine setting#107372

Open
evillique wants to merge 4 commits into
ClickHouse:masterfrom
evillique:deprecate-cloud-mode-database-engine
Open

Deprecate the cloud_mode_database_engine setting#107372
evillique wants to merge 4 commits into
ClickHouse:masterfrom
evillique:deprecate-cloud-mode-database-engine

Conversation

@evillique

@evillique evillique commented Jun 12, 2026

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

...

@clickhouse-gh

clickhouse-gh Bot commented Jun 12, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

@clickhouse-gh clickhouse-gh Bot added the pr-not-for-changelog This PR should not be mentioned in the changelog label Jun 12, 2026
@alexey-milovidov alexey-milovidov mentioned this pull request Jun 13, 2026
Merged
@clickhouse-gh

clickhouse-gh Bot commented Jun 15, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

📊 Cloud Performance Report

✅ AI verdict: no_change — no significant changes across 38 queries analysed

This PR obsoletes the cloud_mode_database_engine setting and only changes CREATE DATABASE engine-selection plumbing, settings declarations, and integration tests. None of that runs during ClickBench's read-only SELECT queries, so the four flagged improvements (Q4 -10%, Q15 -16%, Q28 -7%, Q33 -5%) cannot plausibly come from this change and have been downgraded to not-sure as run-to-run variance. The two already-uncertain queries (Q18, Q32) likewise show deltas unrelated to anything this PR touches. Net: no real performance impact expected from this change.

clickbench

⚠️ 6 inconclusive

Flagged queries (6 of 43)
Query Verdict Baseline median (ms) PR median (ms) Change q-value Hint
⚠️ 4 not_sure 265 238 -10.2% <0.0001 PR only obsoletes a CREATE DATABASE cloud setting; cannot touch this SELECT path. -10% is run-to-run variance.
⚠️ 15 not_sure 249 210 -15.7% <0.0001 DDL-only change (cloud_mode_database_engine obsoletion); read path untouched, so -15.7% is noise.
⚠️ 18 not_sure 1345 1269 -5.7% <0.0001 not_sure stands; PR touches only CREATE DATABASE engine selection, unrelated to SELECT execution.
⚠️ 28 not_sure 7023 6537 -6.9% <0.0001 Low-variance -486ms looks clean but PR only obsoletes a cloud DDL setting; off-path, treat as variance.
⚠️ 32 not_sure 1340 1272 -5.1% <0.0001 not_sure stands; DDL-engine-selection change cannot affect this query's execution.
⚠️ 33 not_sure 1479 1405 -5.0% <0.0001 PR is CREATE DATABASE plumbing only; -5% improvement not plausibly caused here, treat as variance.

q-value = BH-FDR adjusted p; smaller is stronger evidence. MIRAI flags a query when q < fdr_q (default 0.10) — the value the verdict is based on.

tpch_adapted_1_official

🟢 No significant changes

Debug info
  • StressHouse run: f331fd41-f42f-4ba2-973b-c99001859b2f
  • MIRAI run: 7f5a34e2-ea94-4c0c-9413-195311f7d57a
  • PR check IDs:
    • clickbench_27019_1782253459
    • clickbench_27033_1782253459
    • clickbench_27039_1782253459
    • tpch_adapted_1_official_27045_1782253459
    • tpch_adapted_1_official_27052_1782253459
    • tpch_adapted_1_official_27070_1782253459

@thevar1able thevar1able self-assigned this Jun 16, 2026
@evillique evillique enabled auto-merge June 16, 2026 17:53
@evillique evillique disabled auto-merge June 16, 2026 21:07
@evillique evillique enabled auto-merge June 16, 2026 21:07
@clickhouse-gh

clickhouse-gh Bot commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

LLVM Coverage Report

Metric Baseline Current Δ
Lines 85.20% 85.20% +0.00%
Functions 92.30% 92.30% +0.00%
Branches 77.40% 77.40% +0.00%

Changed lines: Changed C/C++ lines covered by tests: 14/14 (100.00%) | Lost baseline coverage: none · Uncovered code

Full report · Diff report

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thevar1able thevar1able thevar1able approved these changes

Assignees

@thevar1able thevar1able

Labels

pr-not-for-changelog This PR should not be mentioned in the changelog

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@evillique @thevar1able @alexey-milovidov