Forbid partial read for read in order with virtulal row by vdimir · Pull Request #106429 · ClickHouse/ClickHouse · GitHub
Skip to content

Forbid partial read for read in order with virtulal row#106429

Merged
alexey-milovidov merged 1 commit into
masterfrom
vdimir/virtual_row_fix_partial_read
Jun 5, 2026
Merged

Forbid partial read for read in order with virtulal row#106429
alexey-milovidov merged 1 commit into
masterfrom
vdimir/virtual_row_fix_partial_read

Conversation

@vdimir

@vdimir vdimir commented Jun 4, 2026

Copy link
Copy Markdown
Member

Changelog category (leave one):

  • Critical Bug Fix (crash, data loss, RBAC)

Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):

  • Fix sporadic incorrect results for ORDER BY ... DESC queries when reading wide parts in reverse order with read_in_order_use_virtual_row_per_block = 1 and a small max_block_size.

Closes #106026

Version info

  • Merged into: 26.6.1.407
  • Backported to: 26.5.2.34, 26.4.4.37

@clickhouse-gh

clickhouse-gh Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

@clickhouse-gh clickhouse-gh Bot added pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels Jun 4, 2026
Comment thread src/Processors/QueryPlan/ReadFromMergeTree.cpp Outdated
@vdimir vdimir force-pushed the vdimir/virtual_row_fix_partial_read branch from 9ccaa2f to 76e4e79 Compare June 4, 2026 10:07
@clickhouse-gh

clickhouse-gh Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

LLVM Coverage Report

Metric Baseline Current Δ
Lines 84.40% 84.40% +0.00%
Functions 92.40% 92.30% -0.10%
Branches 77.00% 77.00% +0.00%

Changed lines: Changed C/C++ lines covered by tests: 14/14 (100.00%) | Lost baseline coverage: none · Uncovered code

Full report · Diff report

@alexey-milovidov alexey-milovidov self-assigned this Jun 5, 2026
@alexey-milovidov alexey-milovidov added this pull request to the merge queue Jun 5, 2026
Merged via the queue into master with commit 59441d8 Jun 5, 2026
166 checks passed
@alexey-milovidov alexey-milovidov deleted the vdimir/virtual_row_fix_partial_read branch June 5, 2026 05:02
robot-ch-test-poll4 added a commit that referenced this pull request Jun 5, 2026
Cherry pick #106429 to 26.5: Forbid partial read for read in order with virtulal row
robot-clickhouse added a commit that referenced this pull request Jun 5, 2026
@robot-clickhouse-ci-2 robot-clickhouse-ci-2 added the pr-synced-to-cloud The PR is synced to the cloud repo label Jun 5, 2026
@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR label Jun 5, 2026
vdimir added a commit that referenced this pull request Jun 5, 2026
Backport #106429 to 26.5: Forbid partial read for read in order with virtulal row
robot-clickhouse-ci-2 added a commit that referenced this pull request Jun 5, 2026
Cherry pick #106429 to 26.4: Forbid partial read for read in order with virtulal row
robot-clickhouse added a commit that referenced this pull request Jun 5, 2026
@robot-clickhouse robot-clickhouse added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label Jun 5, 2026
alexey-milovidov added a commit that referenced this pull request Jun 6, 2026
Backport #106429 to 26.4: Forbid partial read for read in order with virtulal row
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-critical-bugfix pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-synced The `*-must-backport` labels are synced into the cloud Sync PR pr-synced-to-cloud The PR is synced to the cloud repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants