{{ message }}
Disable 04218_limit_by_partitions_independently under MSan (test timeout)#105842
Merged
Conversation
The test (added in ClickHouse#105126) has ~30 scenarios that each do INSERT + EXPLAIN, and the MSan slowdown pushes it past the per-test timeout. It is consistently flaky on `Stateless tests (amd_msan, ...)` while passing on every other sanitizer/build flavor. Adding `no-msan` since the test exercises pipeline planning, not memory correctness, so MSan adds little signal. CI report (first failing master commit, sha 69102a31ed94): https://d1k2gkhrlfqv31.cloudfront.net/clickhouse-test-reports-private/json.html?REF=master&sha=69102a31ed94&name_0=MasterCI&name_1=Stateless%20tests%20%28amd_msan%2C%20meta%20in%20keeper%2C%20s3%20storage%2C%20parallel%2C%202%2F2%29
nihalzp
approved these changes
May 26, 2026
Member
Contributor
|
Workflow [PR], commit [1bec1e6] AI ReviewSummaryThis PR updates Final Verdict
|
Contributor
LLVM Coverage ReportChanged lines: No C/C++ source files changed — skipping uncovered code analysis. Newly covered by added/modified tests: 374 line(s), 76 function(s) across 129 file(s) · Details Top files
|
Merged
via the queue into
ClickHouse:master
with commit May 27, 2026
c15c432
163 of 165 checks passed
robot-ch-test-poll
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test
04218_limit_by_partitions_independently(added in #105126) has ~30 scenarios that each doINSERT INTO ... numbers_mt(1e3)and thenEXPLAIN actions = 1. Under MSan, the cumulative cost pushes the test past the per-test timeout: inStateless tests (amd_msan, meta in keeper, s3 storage)the test now fails on the majority of runs since #105126 landed, while passing on every other sanitizer/build flavor.Adding
no-msanbecause the test exercises pipeline planning (per-partitionLimitByTransformfan-out), not memory correctness, so MSan adds little signal here. A follow-up could shrink the per-scenario row counts to restore MSan coverage; this PR is the minimal fix to unblock CI.Failure mode in CI is a client-side timeout while waiting for results —
__GI___poll->Poco::Net::SocketImpl::pollImpl->DB::ClientBase::receiveResult.CI report (first failing master commit, sha
69102a31ed94, 2026-05-25 06:48 UTC, ~25 min after #105126 was merged):https://s3.amazonaws.com/clickhouse-test-reports/json.html?REF=master&sha=69102a31ed94&name_0=MasterCI&name_1=Stateless%20tests%20%28amd_msan%2C%20meta%20in%20keeper%2C%20s3%20storage%2C%20parallel%2C%202%2F2%29
No open issue exists for this; searches for
04218,04218_limit_by_partitions_independently, andallow_limit_by_partitions_independentlyagainstClickHouse/ClickHousereturned nothing.Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Version info
26.6.1.175