{{ message }}
Fix flaky 02504_regexp_dictionary_ua_parser on parallel replicas + s3#104666
Merged
murphy-4o merged 1 commit intoMay 12, 2026
Conversation
Qualify the three dictGet dictionary names with ${CLICKHOUSE_DATABASE}
so the worker can resolve them without depending on its current_database.
On parallel-replica runs (the parallel_replicas cluster has no
<default_database>), the worker's current_database is empty, so an
unqualified dictGet('regexp_os', ...) — kept as a string literal through
formattedAST — fails resolveDictionaryNameFromDatabaseCatalog and throws
"Dictionary (regexp_os) not found" during getReturnTypeImpl on the
worker. parallel_replicas_local_plan=1 normally hides this because the
typing call stays on the initiator; randomized settings expose it.
Test-side workaround. Removes the test from parallel_replicas_blacklist
so the FAIL→SKIPPED conversion no longer masks regressions. The
underlying engine bug — workers should inherit the initiator's
current_database, or unqualified dict literals should be rewritten to
UUIDs before dispatch — is left as a separate fix.
murphy-4o
force-pushed
the
fix-02504-regexp-dict-flaky
branch
from
66bdf37 to
c2b8abe
Compare
Contributor
alesapin
approved these changes
May 12, 2026
robot-ch-test-poll4
added
the
pr-synced-to-cloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry:
Not required (CI fix).
Documentation entry for user-facing changes
Qualifies the three
dictGetcalls in02504_regexp_dictionary_ua_parser.shwith${CLICKHOUSE_DATABASE}.so the test passes deterministically under parallel replicas.Why it flakes:
dictGet's first argument is kept as a string literal end-to-end. On parallel-replica workers theparallel_replicascluster has no<default_database>(andClientInfodoesn't carry one), so the worker'scurrent_databaseis empty. Whenparallel_replicas_local_plan=0(e.g. randomized) routes thegetReturnTypeImpltyping call to a worker,ExternalDictionariesLoader::resolveDictionaryNamecan't findregexp_osin the test database and throwsDictionary (regexp_os) not found. Qualifying the literal with the database name skips thecurrent_databasefallback in the resolver.Smallest-blast-radius fix; the underlying engine issue (workers should inherit
current_database, or dict literals should be UUID-rewritten before dispatch) is left for a separate PR. Pairs with #104627 which already took this test off the blacklist.Version info
26.5.1.551