{{ message }}
Update SettingsChangesHistory.cpp#104097
Merged
antaljanosbenjamin merged 2 commits intoMay 6, 2026
Merged
Conversation
Contributor
Member
Author
clickhouse-gh
Bot
added
the
pr-not-for-changelog
Algunenano
approved these changes
May 5, 2026
Contributor
LLVM Coverage Report
Changed lines: 100.00% (12/12) · Uncovered code |
Member
|
Why did |
Member
Author
Good question. I briefly tried to figure it out, but failed in 10 minutes. I will have a look at it, but based on CIDB it doesn't look like a unique issue. |
Member
Author
antaljanosbenjamin
deleted the
fix-settings-changes-history-after-backporting-auto-spilling-join
branch
robot-ch-test-poll
added
the
pr-synced-to-cloud
1 task
pull Bot
pushed a commit
to admariner/ClickHouse
that referenced
this pull request
May 6, 2026
The flaky-check driver derives a test name from each changed file under `tests/queries/0_stateless/` by stripping the file extension. When PR ClickHouse#104097 changed only `02995_settings_26_4_1.tsv` (a data file consumed by `02995_new_settings_history.sh`), the driver produced the bogus pattern `02995_settings_26_4_1.` and asked `clickhouse-test` to re-run it 50 times. No test matches that pattern, so `clickhouse-test` printed `Found 0 parallel tests and 0 sequential tests` and exited with code 1, failing the flaky check. Match files first against the known test extensions (`.sql`, `.sql.j2`, `.sh`, `.py`, `.expect`); for supporting files such as `.reference` or `.reference.j2`, walk back one extension at a time looking for a sibling test source. Orphan data files like `02995_settings_26_4_1.tsv` are now skipped instead of producing a filter that matches zero tests. See ClickHouse#104097 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
FYI @alexey-milovidov
Documentation entry for user-facing changes
Version info
26.5.1.326