{{ message }}
Raise concurrent_threads_soft_limit_ratio_to_cores code default to 2#103446
Open
alexey-milovidov wants to merge 2 commits intomasterfrom
Open
Raise concurrent_threads_soft_limit_ratio_to_cores code default to 2#103446alexey-milovidov wants to merge 2 commits intomasterfrom
alexey-milovidov wants to merge 2 commits intomasterfrom
Conversation
Bump the shipped default in `config.xml` from 2 to 10 and the in-code fallback in `ServerSettings.cpp` from 0 to 10, so the concurrent threads scheduler (`max_min_fair`) effectively caps the total number of query processing threads at 10x the number of CPU cores out of the box. Related: #86516, #89542. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
clickhouse-gh
Bot
added
the
pr-improvement
Keep `programs/server/config.xml` at the existing `2` and align the in-code fallback in `ServerSettings.cpp` with it. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
alexey-milovidov
changed the title
Contributor
LLVM Coverage ReportChanged lines: 100.00% (6/6) · Uncovered code |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Align the in-code fallback of
concurrent_threads_soft_limit_ratio_to_coresinsrc/Core/ServerSettings.cppwith the shippedprograms/server/config.xmlvalue, so both are2.Previously the code default was
0(unlimited) whileconfig.xmlshipped2, meaning themax_min_fairscheduler effectively had no cap for anyone running without the shippedconfig.xml.Related history: #86516, #89542.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Align the default of the server setting
concurrent_threads_soft_limit_ratio_to_coresin code with the shippedconfig.xmlvalue (2), so the defaultmax_min_fairconcurrent threads scheduler caps query processing threads at 2x cores out of the box even when the shippedconfig.xmlis not used.Documentation entry for user-facing changes