{{ message }}
Cherry pick #101178 to 25.8: Fix crash when GLOBAL IN set lacks explicit elements during DIA#102712
Closed
robot-clickhouse-ci-1 wants to merge 10 commits into
Closed
Cherry pick #101178 to 25.8: Fix crash when GLOBAL IN set lacks explicit elements during DIA#102712robot-clickhouse-ci-1 wants to merge 10 commits into
robot-clickhouse-ci-1 wants to merge 10 commits into
Conversation
…ed index analysis When distributed index analysis (DIA) encounters a GLOBAL IN predicate whose set has been built without explicit elements (e.g. because use_index_for_in_with_subqueries_max_values was exceeded during buildOrderedSetInplace), setExternalTable() would crash with: "Trying to attach external table to a ready set without explicit elements" This happened in stress tests where the AST fuzzer could produce queries with GLOBAL IN on tables with DIA enabled, and the set had too many elements to retain explicit values (only hashes remained). The fix adds a check in tryBuildAdditionalFilterAST(): if the set is already built without explicit elements, the GLOBAL IN predicate is skipped from the distributed filter. DIA still functions correctly — it just won't use this predicate for remote index analysis, which is a slight optimization loss but maintains correctness. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…t-set-elements Fix crash when GLOBAL IN set lacks explicit elements during DIA
robot-clickhouse-ci-1
added
pr-cherrypick
robot-clickhouse
force-pushed
the
backport/25.8/101178
branch
from
1060b18 to
db8f13e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original pull-request #101178
Do not merge this PR manually
This pull-request is a first step of an automated backporting.
It contains changes similar to calling
git cherry-picklocally.If you intend to continue backporting the changes, then resolve all conflicts if any.
Otherwise, if you do not want to backport them, then just close this pull-request.
The check results does not matter at this step - you can safely ignore them.
Troubleshooting
If the conflicts were resolved in a wrong way
If this cherry-pick PR is completely screwed by a wrong conflicts resolution, and you want to recreate it:
pr-cherrypicklabel from the PRYou also need to check the Original pull-request for
pr-backports-createdlabel, and delete if it's presented thereThe PR source
The PR is created in the CI job