{{ message }}
Fix exception in throwUnexpectedDataAfterParsedValue for empty Tuple() type#102011
Merged
Conversation
…le()` type `throwUnexpectedDataAfterParsedValue` calls `popBack(1)` assuming the parsed value is already committed to the column. For tuples, it is called from inside `addElementSafe`'s impl lambda before `addSize(1)` commits the row. For `Tuple()` with no sub-columns, `column.size()` returns 0, so `popBack(1)` throws "Cannot pop 1 rows from Tuple(): there are only 0 rows". Fix by calling `addSize(1)` to commit the row before `throwUnexpectedDataAfterParsedValue`, which will serialize it for the error message and then pop it back. Found by the AST fuzzer: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=102000&sha=9190a5549402d12fff136f61209c5405f2aa896c&name_0=PR&name_1=AST%20fuzzer%20%28amd_debug%2C%20targeted%2C%20old_compatibility%29 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
clickhouse-gh
Bot
added
the
pr-bugfix
Member
Author
|
The test |
Contributor
LLVM Coverage Report
Changed lines: 100.00% (8/8) · Uncovered code |
alexey-milovidov
added a commit
that referenced
this pull request
Apr 8, 2026
The `stop_server` function retries `SYSTEM STOP DISTRIBUTED SENDS` up to 30 times before calling `clickhouse stop`. When the server is unresponsive (e.g. after a stress test), each attempt waits for the default `receive_timeout` of 300 seconds. This means the loop can burn 30 × 300 = 9000 seconds (2.5 hours) before proceeding to actually stop the server, consuming the entire CI job timeout. Add `--receive_timeout=10` so each attempt fails within 10 seconds when the server is unresponsive. Worst case the loop now takes 30 × 10 = 300 seconds instead of 9000. Found in: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=102011&sha=8ed7fb8bcfdac4af8d2a062200b104281178981b&name_0=PR&name_1=Stress%20test%20%28arm_tsan%29 PR: #102011 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
evillique
approved these changes
Apr 9, 2026
Member
Author
robot-clickhouse-ci-1
added
the
pr-synced-to-cloud
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
throwUnexpectedDataAfterParsedValuecallspopBack(1)assuming the parsed value is already committed to the column. For tuples, it is called from insideaddElementSafe's impl lambda beforeaddSize(1)commits the row. ForTuple()with no sub-columns,column.size()returns 0, sopopBack(1)throws "Cannot pop 1 rows from Tuple(): there are only 0 rows".Fix by calling
addSize(1)to commit the row beforethrowUnexpectedDataAfterParsedValue, which will serialize it for the error message and then pop it back.Found by the AST fuzzer: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=102000&sha=9190a5549402d12fff136f61209c5405f2aa896c&name_0=PR&name_1=AST%20fuzzer%20%28amd_debug%2C%20targeted%2C%20old_compatibility%29
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
Fix exception when casting a string with trailing data to empty
Tuple()type.Documentation entry for user-facing changes
Version info
26.4.1.744