{{ message }}
Stabilize 03772_temporary_files_codec test#101995
Merged
Merged
Conversation
Contributor
PedroTadim
changed the title
![clickhouse-gh[bot]](https://avatars.githubusercontent.com/in/928874?s=60&v=4){kind=small}
Member
|
The test |
alexey-milovidov
approved these changes
Apr 8, 2026
PedroTadim
changed the title
robot-ch-test-poll
added
the
pr-synced-to-cloud
Member
This is wrong, settings that set with SET query has a priority over the randomized settings, so I don't see how this fixes the test |
Member
1 task
nihalzp
pushed a commit
to nihalzp/ClickHouse
that referenced
this pull request
May 17, 2026
The five SELECT/GROUP BY queries (sort × 2, agg × 3) each carried per-query `SETTINGS` clauses re-pinning `max_bytes_before_external_sort`, `max_bytes_ratio_before_external_sort`, `max_bytes_before_external_group_by`, and `max_bytes_ratio_before_external_group_by` to the exact same values that are already pinned at session level by the `SET` statements at the top of the file. Session `SET` already overrides the test runner's randomization, so the per-query `SETTINGS` were redundant noise. Removing them keeps the session-level pins (the authoritative ones) and leaves only query-specific settings (`log_comment`, `temporary_files_codec`) on each query. Verified by running the test 30 times with randomization (`-- Tags: long` temporarily removed to allow more iterations): 30/30 passed. `long` tag restored before commit. Follow-up to ClickHouse#101995 and ClickHouse#102195, addressing @azat's request to clean up the test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changelog category (leave one):
Changelog entry (a user-readable short description of the changes that goes into CHANGELOG.md):
...
Failure here https://s3.amazonaws.com/clickhouse-test-reports/json.html?REF=master&sha=d2f57548e7eed2deb6a65aa93c50bbe8209873ae&name_0=MasterCI&name_1=Stateless+tests+%28amd_msan%2C+WasmEdge%2C+parallel%2C+1%2F2%29
Claude code fix
"The test forces external sort/group_by via session SET, but the randomizer can inject max_bytes_before_external_sort = 0 and max_bytes_ratio_before_external_sort = 0 via CLI. The inline SETTINGS clause in each query has highest priority — so pinning the thresholds there is the cleanest fix"
Documentation entry for user-facing changes
Version info
26.4.1.680